Skip to content

FEAUTRE: Hide messages count in sidebar with feature flag #33774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

martin-brennan
Copy link
Contributor

Followup 037670f

This commit adds a experimental_sidebar_messages_count_enabled_groups
site setting feature flag to control the visibility of the messages count/
icon in the sidebar while we work out some kinks with the
functionality. By default this feature is disabled.

Copy link
Contributor

@tgxworld tgxworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but there is a spec failure due to missing translation for the new site setting.

Followup 037670f

This commit adds a experimental_sidebar_messages_count_enabled_groups
site setting feature flag to control the visibility of the messages count/
icon in the sidebar while we work out some kinks with the
functionality. By default this feature is disabled.
@martin-brennan martin-brennan force-pushed the feature/experimental-sidebar-messages-count branch from 4daecee to 55ad425 Compare July 23, 2025 01:02
@martin-brennan
Copy link
Contributor Author

@tgxworld yup ty just pushed up that fix 🙏

@github-actions github-actions bot added the i18n PRs which update English locale files or i18n related code label Jul 23, 2025
@martin-brennan martin-brennan merged commit c7baa18 into main Jul 23, 2025
13 of 15 checks passed
@martin-brennan martin-brennan deleted the feature/experimental-sidebar-messages-count branch July 23, 2025 01:14
yuriyaran added a commit that referenced this pull request Aug 8, 2025
yuriyaran added a commit that referenced this pull request Aug 11, 2025
Removes the temporary `experimental_sidebar_messages_count_enabled_groups` site setting.

Reverts #33774.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n PRs which update English locale files or i18n related code
Development

Successfully merging this pull request may close these issues.

2 participants