FIX: Use a valid value for disabling backups using backup_frequency #34245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
commented
Aug 12, 2025
| @@ -8,7 +8,7 @@ class ScheduleBackup < ::Jobs::Scheduled | |||
| def execute(args) | |||
| delete_prior_to_n_days | |||
| return if !SiteSetting.enable_backups? | |||
| return if SiteSetting.backup_frequency.blank? | |||
There was a problem hiding this comment.
This is a problem, because if it is NULL in the database, the type system will coerce to 0 and it won't be blank?.
martin-brennan
approved these changes
Aug 12, 2025
Co-authored-by: Martin Brennan <martin@discourse.org>
yuriyaran
pushed a commit
that referenced
this pull request
Aug 21, 2025
…34245) In #33558 we removed automatic_backups_enabled setting, and instead rely on backup_frequency being blank to disable. There was a big oversight there with the site setting type system, which will coerce the value to an integer. It also makes it so you can't blank the value out in the UI. This is a "fix forward" solution where instead of "set to blank to disable" we do "set to 0 to disable". This works along the grain of the site setting type system for a workable fix where we don't have to deal with the irreversible migration in the previous change. We can potentially go and add in "nullable" to the type system at a later point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
In #33558 we removed
automatic_backups_enabledsetting, and instead rely onbackup_frequencybeing blank to disable.There was a big oversight there with the site setting type system, which will coerce the value to an integer. It also makes it so you can't blank the value out in the UI.
How does this fix it?
This is a "fix forward" solution where instead of "set to blank to disable" we do "set to 0 to disable". This works along the grain of the site setting type system for a workable fix where we don't have to deal with the irreversible migration in the previous change.
We can potentially go and add in "nullable" to the type system at a later point.