Skip to content

DEV: Remove invalid options from migrations #34384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DEV: Remove invalid options from migrations #34384

wants to merge 1 commit into from

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Aug 18, 2025 •
edited
Loading

The change is sponsored by Rails/AddColumnIndex rubocop rule:

(…) add_column does not accept index, but also does not raise an error for extra keys, so it is possible to mistakenly add the key without realizing it will not actually add an index.

I opted not to add these "missing" indexes since they've proven not necessary after all.

@CvX
DEV: Remove invalid options from migrations
64a72cf 
The change is sponsored by `Rails/AddColumnIndex` rubocop rule.

I opted not to add these "missing" indexes since they've proven not necessary after all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CvX