Remove duplicate entries from intersection additional tags #34389
Conversation
…onal tags in the tags/in tersection path
app/controllers/tags_controller.rb
Outdated
| params[:additional_tag_ids] = ( | ||
| if additional_tags_trimmed.present? | ||
| additional_tags_trimmed.join("/") | ||
| else | ||
| nil | ||
| end | ||
| ) |
There was a problem hiding this comment.
| params[:additional_tag_ids] = ( | |
| if additional_tags_trimmed.present? | |
| additional_tags_trimmed.join("/") | |
| else | |
| nil | |
| end | |
| ) | |
| if additional_tags_trimmed.present? | |
| params[:additional_tag_ids] = additional_tags_trimmed.join("/") | |
| end |
There was a problem hiding this comment.
Hmm... In case params[:additional_tag_ids] was already set, and the duplicate removal logic removes all entries (emptying additional_tags_trimmed, I need to clear params[:additional_tag_ids], which is why I'm setting it to nil explicitly here.
For instance, if params[:tag_id] = "tag1" and params[:additional_tag_ids] = "tag1", then I want to end up with params[:additional_tag_ids] = nil.
Maybe there's still a cleaner way than what I wrote?
There was a problem hiding this comment.
Looks like it's enough to do params[:additional_tag_ids] = additional_tags_trimmed&.join("/"). Was thinking I needed to set the param to nil but setting it to "" (in case the array is empty) works just as well to clear the param.
Remove duplicate entries (or repeats of the main tag) from the additional tags in the tags/intersection path. This was causing unexpected behavior when the main tag was repeated again in the additional tags (which isn't typically possible by the core UI, but is possible in custom plugins or by directly editing the URL). See https://meta.discourse.org/t/377740
Remove duplicate entries (or repeats of the main tag) from the additional tags in the tags/intersection path.
This was causing unexpected behavior when the main tag was repeated again in the additional tags (which isn't typically possible by the core UI, but is possible in custom plugins or by directly editing the URL).
See https://meta.discourse.org/t/377740