Skip to content

FIX: Update i18n key for toggle localization button #34405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
+16 −3
Merged

FIX: Update i18n key for toggle localization button #34405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/assets/javascripts/discourse/app/components/topic-localized-content-toggle.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ export default class TopicLocalizedContentToggle extends Component {

get title() {
return this.showingOriginal
? "translator.content_not_translated"
: "translator.content_translated";
? "content_localization.toggle_localized.not_translated"
: "content_localization.toggle_localized.translated";
}

<template>
Expand Down
4 changes: 4 additions & 0 deletions config/locales/client.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5580,6 +5580,10 @@ en:
default: "%{filter} topics in %{category} without tags"

categories: "All categories"
content_localization:
toggle_localized:
translated: "Page is machine-translated. Click to view original."
not_translated: "Page is not translated. Click to translate."

# This section is exported to the javascript for i18n in the admin section
admin_js:
Expand Down
11 changes: 10 additions & 1 deletion spec/system/content_localization_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# frozen_string_literal: true

describe "Content Localization" do
TOGGLE_LOCALIZE_BUTTON_SELECTOR = "button.btn-toggle-localized-content"

fab!(:japanese_user) { Fabricate(:user, locale: "ja") }
fab!(:site_local_user) { Fabricate(:user, locale: "en") }
fab!(:admin)
Expand Down Expand Up @@ -68,9 +70,16 @@
topic_list.visit_topic_with_title("孫子兵法からの人生戦略")

expect(topic_page.has_topic_title?("孫子兵法からの人生戦略")).to eq(true)
page.find("button.btn-toggle-localized-content").click

expect(page.find(TOGGLE_LOCALIZE_BUTTON_SELECTOR)["title"]).to eq(
I18n.t("js.content_localization.toggle_localized.translated"),
)
page.find(TOGGLE_LOCALIZE_BUTTON_SELECTOR).click

expect(topic_page.has_topic_title?("Life strategies from The Art of War")).to eq(true)
expect(page.find(TOGGLE_LOCALIZE_BUTTON_SELECTOR)["title"]).to eq(
I18n.t("js.content_localization.toggle_localized.not_translated"),
)

visit("/")
topic_list.visit_topic_with_title("Life strategies from The Art of War")
Expand Down
Loading