FIX: Handle auxclick event on topic list #34408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new `auxclick` event handler to the topic list item, which calls the same `click` handler. The `auxclick` event is triggered by auxiliary mouse buttons, such as the middle mouse button. This fixes an issue where using the middle mouse button on a topic card in Horizon anywhere but the topic title would not open the topic in a new tab. Normal topic list click functionality remains unchanged. c.f. https://developer.mozilla.org/en-US/docs/Web/API/Element/auxclick_event
martin-brennan
commented
Aug 19, 2025
| @@ -238,6 +238,7 @@ export default class Item extends Component { | |||
| {{this.highlightIfNeeded}} | |||
| {{on "keydown" this.keyDown}} | |||
| {{on "click" this.click}} | |||
| {{on "auxclick" this.click}} | |||
There was a problem hiding this comment.
This is the main change of this PR
| @@ -117,6 +117,7 @@ export default { | |||
| metaKey: event.metaKey, | |||
| shiftKey: event.shiftKey, | |||
| button: event.button, | |||
| which: event.which, | |||
There was a problem hiding this comment.
May as well pass this through to the new event:
https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/which#value_for_mouseevent_non-standard
CvX
approved these changes
Aug 19, 2025
yuriyaran
pushed a commit
that referenced
this pull request
Aug 21, 2025
This commit adds a new `auxclick` event handler to the topic list item, which calls the same `click` handler. The `auxclick` event is triggered by auxiliary mouse buttons, such as the middle mouse button. This fixes an issue where using the middle mouse button on a topic card in Horizon anywhere but the topic title would not open the topic in a new tab. Normal topic list click functionality remains unchanged. c.f. https://developer.mozilla.org/en-US/docs/Web/API/Element/auxclick_event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
auxclickevent handler to the topic list item,which calls the same
clickhandler.The
auxclickevent is triggered by auxiliary mouse buttons, such asthe middle mouse button. This fixes an issue where using the middle mouse button
on a topic card in Horizon anywhere but the topic title would not open the topic
in a new tab.
Normal topic list click functionality remains unchanged.
c.f. https://developer.mozilla.org/en-US/docs/Web/API/Element/auxclick_event
The areas in red were "dead zones" for middle click: