FIX: Don't leave blank additional_tag_ids param after removing dups in intersection #34423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
approved these changes
Aug 19, 2025
yuriyaran
pushed a commit
that referenced
this pull request
Aug 21, 2025
…n intersection (#34423) My previous fix would leave behind a blank `additional_tag_ids=` query param when redirecting to /tag if all additional_tags in the intersection route were removed due to being duplicates. With this fix the additional_tag_ids param is removed if it ends up being cleared during the duplicate check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous fix would leave behind a blank
additional_tag_ids=query param when redirecting to /tag if all additional_tags in the intersection route were removed due to being duplicates. For instance,/tags/intersection/tag1/tag1would redirect to/tag/tag1?additional_tag_ids=. Probably harmless but not intentional.With this fix the additional_tag_ids param is removed if it ends up being cleared during the duplicate check, so the above example will redirect to
/tag/tag1with theadditional_tag_idsparam omitted.