FIX: DiscourseConnect and auth_immediately = false #34424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
reviewed
Aug 19, 2025
pmusaraj
reviewed
Aug 19, 2025
b67f9e0 to
0bed875
Compare
|
@pmusaraj I've simplified the logic and made the |
DiscourseConnect "required" auth_immediately to also be enabled to work properly but this was incorrect. This fixes that assumption and add specs to cover all combinations of - login_required - auth_immediately - visiting / - visiting / and clicking the login button - visiting /login directly Internal ref - t/161485
instead of when some combination of site settings is present.
0bed875 to
8899044
Compare
pmusaraj
approved these changes
Aug 20, 2025
| @@ -35,6 +35,7 @@ export default class extends DiscourseRoute { | |||
| const { referrer } = document; | |||
| const { canSignUp } = this.controllerFor("application"); | |||
| const { isOnlyOneExternalLoginMethod, singleExternalLogin } = this.login; | |||
| const redirect = auth_immediately || login_required || !from || wantsTo; | |||
There was a problem hiding this comment.
For a follow-up, it's a little unclear what the !from and wantTo properties here represent.
There was a problem hiding this comment.
from comes from the transition object which lets us differentiate between in-app navigation vs full-page navigation.
wantsTo is when you click a button in the app, for which the event bubbles up to the application route and calls either the showLogin or showCreateAccount action.
More than happy to rename them if you have ideas!
ZogStriP
added a commit
that referenced
this pull request
Aug 20, 2025
DiscourseConnect "required" auth_immediately to also be enabled to work properly but this was incorrect. This fixes that assumption and add specs to cover all combinations of - login_required - auth_immediately - visiting / - visiting / and clicking the login button - visiting /login directly Internal ref - t/161485
yuriyaran
pushed a commit
that referenced
this pull request
Aug 21, 2025
DiscourseConnect "required" auth_immediately to also be enabled to work properly but this was incorrect. This fixes that assumption and add specs to cover all combinations of - login_required - auth_immediately - visiting / - visiting / and clicking the login button - visiting /login directly Internal ref - t/161485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscourseConnect "required" auth_immediately to also be enabled to work properly but this was incorrect.
This fixes that assumption and add specs to cover all combination of
Internal ref - t/161485