FEATURE: Add ActivityPub topic map, topic actions, post actions and topic info, and update ActivityPub post info. #161
Conversation
|
Thanks @angusmcleod, I'm going to review this over the weekend into Monday and plan to merge early next week! |
There was a problem hiding this comment.
Overall this is looking great. I have gone over about 60% of the code here and tested it on my instance, not seeing any major issues. Left some minor comments in the code.
One thing to note with ingested posts is that the "published" copy doesn't sound right.
I would opt for something like "Ingested from source at date". I'm not sure we need "OrderedCollection" here, it seems too technical. We could also change the title to "ActivityPub Log for Topic #122".
Also, instead of having two lines:
- Article was published on...
- Original Article on ...
We could have one,
- Originally published on source at date (linked to the source)
I think the type (Article/Note) and visibility could go in the same line:
- Type: Article -- Visibility: Public
This would reduce the duplication of dates/metadata in the outgoing objects as well:
Not sure if this is clear, happy to provide a mockup if you prefer. Overall, this worked great in my quick testing, clearer than before and I like the additional controls for admins.
assets/javascripts/discourse/connectors/topic-map/topic-map-activity-pub.hbs
Outdated
Show resolved
Hide resolved
assets/javascripts/discourse/connectors/topic-map/topic-map-activity-pub.js
Outdated
Show resolved
Hide resolved
assets/javascripts/discourse/components/modal/activity-pub-topic-info.hbs
Outdated
Show resolved
Hide resolved
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
…tivity-pub.js Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
|
@pmusaraj Thanks for the feedback. I've addressed the specific code feedback and am working on improving the ActivityPub info along the lines you laid out. |
@pmusaraj This PR does the following:
Here's a narrative as to why the additional changes (in addition to the topic map) these changes are needed:
https://www.loom.com/share/7cbe6ac12f614f24ac7a481eb901c3a2?sid=11d38c5c-66f0-4b16-9c6d-beba052bf6fe