-
Notifications
You must be signed in to change notification settings - Fork 42
FEATURE: add inferred concepts system #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6c51329
to
74d47a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. It'd be great to add some tests
This commit adds a new inferred concepts system that: - Creates a model for storing concept labels that can be applied to topics - Provides AI personas for finding new concepts and matching existing ones - Adds jobs for generating concepts from popular topics - Includes a scheduled job that automatically processes engaging topics
* Adds support for concepts to be inferred from and applied to posts * Replaces daily task with one that handles both topics and posts * Adds database migration for posts_inferred_concepts join table * Updates PersonaContext to include inferred concepts
e5d2523
to
c1fc3c7
Compare
12f95c6
to
a73e9e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽 Two small suggestions
TEMPLATE_PARAMS = %w[ | ||
time | ||
site_url | ||
site_title | ||
site_description | ||
participants | ||
resource_url | ||
inferred_concepts | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we .freeze
this?
TEMPLATE_PARAMS = %w[ | |
time | |
site_url | |
site_title | |
site_description | |
participants | |
resource_url | |
inferred_concepts | |
] | |
TEMPLATE_PARAMS = %w[ | |
time | |
site_url | |
site_title | |
site_description | |
participants | |
resource_url | |
inferred_concepts | |
].freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's freezed by default, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strings inside the array are frozen, but the array itself is still mutable no?
Co-authored-by: Keegan George <kgeorge13@gmail.com>
This commit adds a new inferred concepts system that: