Skip to content

FEATURE: add inferred concepts system #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jun 2, 2025
Merged

FEATURE: add inferred concepts system #1330

merged 36 commits into from
Jun 2, 2025

Conversation

xfalcox
Copy link
Member

@xfalcox xfalcox commented May 8, 2025

This commit adds a new inferred concepts system that:

  • Creates a model for storing concept labels that can be applied to topics
  • Provides AI personas for finding new concepts and matching existing ones
  • Adds jobs for generating concepts from popular topics
  • Includes a scheduled job that automatically processes engaging topics

@xfalcox xfalcox force-pushed the inferred-concepts branch from 6c51329 to 74d47a9 Compare May 16, 2025 18:43
Copy link
Member

@romanrizzi romanrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. It'd be great to add some tests

xfalcox added 12 commits May 29, 2025 14:42
This commit adds a new inferred concepts system that:
- Creates a model for storing concept labels that can be applied to topics
- Provides AI personas for finding new concepts and matching existing ones
- Adds jobs for generating concepts from popular topics
- Includes a scheduled job that automatically processes engaging topics
* Adds support for concepts to be inferred from and applied to posts
* Replaces daily task with one that handles both topics and posts
* Adds database migration for posts_inferred_concepts join table
* Updates PersonaContext to include inferred concepts
@xfalcox xfalcox force-pushed the inferred-concepts branch from e5d2523 to c1fc3c7 Compare May 29, 2025 17:43
@romanrizzi romanrizzi force-pushed the inferred-concepts branch from 12f95c6 to a73e9e6 Compare May 29, 2025 21:06
@xfalcox xfalcox marked this pull request as ready for review May 30, 2025 14:38
Copy link
Member

@keegangeorge keegangeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽 Two small suggestions

Comment on lines +73 to +81
TEMPLATE_PARAMS = %w[
time
site_url
site_title
site_description
participants
resource_url
inferred_concepts
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we .freeze this?

Suggested change
TEMPLATE_PARAMS = %w[
time
site_url
site_title
site_description
participants
resource_url
inferred_concepts
]
TEMPLATE_PARAMS = %w[
time
site_url
site_title
site_description
participants
resource_url
inferred_concepts
].freeze

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's freezed by default, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings inside the array are frozen, but the array itself is still mutable no?

Co-authored-by: Keegan George <kgeorge13@gmail.com>
@xfalcox xfalcox merged commit 478f31d into main Jun 2, 2025
6 checks passed
@xfalcox xfalcox deleted the inferred-concepts branch June 2, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants