DEV: cancel manager should bypass webmock #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webmock can be a bit flaky under certain use cases.
tgxworld
reviewed
May 19, 2025
| @@ -3,6 +3,8 @@ | |||
| describe DiscourseAi::Completions::CancelManager do | |||
| fab!(:model) { Fabricate(:anthropic_model, name: "test-model") } | |||
|
|
|||
| before { WebMock.allow_net_connect! } | |||
There was a problem hiding this comment.
I’m not following this as it means that we are allowing outgoing http connections in the test environment. Not sure if I am missing something here.
There was a problem hiding this comment.
yes, read downwards, it creates a web server see the current flake, there is a bug in webmock somewhere where it defines local incorrectly.
tgxworld
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webmock can be a bit flaky under certain use cases.