FIX: ensures stream update object is scoped to its initial topic #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit you could end up in this situation where a `post-updater` is constructed for a specific topic, but the user changes topic mid steam and it ends up updating the same post number but in a different topic as we were only checking for `post_number` and not the combination of `topic_id` + `post_number`.
jjaffeux
commented
May 22, 2025
| @@ -57,6 +59,10 @@ export default class PostUpdater extends StreamUpdater { | |||
| } | |||
|
|
|||
| async setCooked(value) { | |||
| if (!this.postElement) { | |||
There was a problem hiding this comment.
do not attempt to find cooked on a non existing element
SamSaffron
approved these changes
May 22, 2025
|
Thanks heaps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit you could end up in this situation where a
post-updateris constructed for a specific topic, but the user changes topic mid steam and it ends up updating the same post number but in a different topic as we were only checking forpost_numberand not the combination oftopic_id+post_number.No test as there's only a unit test at the moment which wouldn't confirm the topic logic.