FEATURE: improve site setting search #780
Conversation
This improves the site setting search so it performs a somewhat fuzzy match. Previously it did not handle seperators such as "space" and a term such as "min_post_length" would not find "min_first_post_length" A more liberal search algorithm makes it easier to the AI to navigate settings.
obviously broken. If parameter.enum is a tracked array it will return the object cause embers and helper implementation. This corrects an issue where enum keeps on selecting itself by mistake.
| described_class.new({ query: query }, bot_user: bot_user, llm: llm) | ||
| def search_settings(query, mock: true) | ||
| search = described_class.new({ query: query }, bot_user: bot_user, llm: llm) | ||
| search.all_settings = fake_settings if mock |
There was a problem hiding this comment.
I think you need an after block to restore the original value of this, or reset it to nil so the memoization can kick in and re-initialize the settings in search_settings.rb
There was a problem hiding this comment.
Otherwise some test flakiness may occur
There was a problem hiding this comment.
An alternative approach is to do DiscourseAi::AiBot::Tools::SearchSettings.any_instance.stubs(:site_settings).returns(mock), then that will automatically get cleaned up
There was a problem hiding this comment.
Or doing the above with SiteSetting.all_settings would avoid needing to add an all_settings method in that class entirely :)
There was a problem hiding this comment.
no need, this is just defining an instance :) the instance and the override vanish after the test
This improves the site setting search so it performs a somewhat
fuzzy match.
Previously it did not handle seperators such as "space" and a
term such as "min_post_length" would not find "min_first_post_length"
A more liberal search algorithm makes it easier to the AI to
navigate settings.