Skip to content

FEATURE: Skip PM scanning in LLM triage by default #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024
Merged

FEATURE: Skip PM scanning in LLM triage by default #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/locales/client.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ en:
flag_post:
label: "Flag post"
description: "Flags post (either as spam or for review)"
include_personal_messages:
label: "Include personal messages"
description: "Also scan and triage personal messages"
model:
label: "Model"
description: "Language model used for triage"
Expand Down
6 changes: 6 additions & 0 deletions discourse_automation/llm_triage.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
field :tags, component: :tags
field :hide_topic, component: :boolean
field :flag_post, component: :boolean
field :include_personal_messages, component: :boolean
field :flag_type,
component: :choices,
required: false,
Expand Down Expand Up @@ -54,6 +55,11 @@

max_post_tokens = nil if max_post_tokens <= 0

if post.topic.private_message?
include_personal_messages = fields.dig("include_personal_messages", "value")
next if !include_personal_messages
end

begin
RateLimiter.new(
Discourse.system_user,
Expand Down
30 changes: 28 additions & 2 deletions spec/lib/discourse_automation/llm_triage_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
describe DiscourseAi::Automation::LlmTriage do
fab!(:category)
fab!(:reply_user) { Fabricate(:user) }
fab!(:personal_message) { Fabricate(:private_message_topic) }
let(:canned_reply_text) { "Hello, this is a reply" }

let(:automation) { Fabricate(:automation, script: "llm_triage", enabled: true) }

Expand All @@ -30,7 +32,7 @@ def add_automation_field(name, value, type: "text")
add_automation_field("tags", %w[aaa bbb], type: "tags")
add_automation_field("hide_topic", true, type: "boolean")
add_automation_field("flag_post", true, type: "boolean")
add_automation_field("canned_reply", "Yo this is a reply")
add_automation_field("canned_reply", canned_reply_text)
add_automation_field("canned_reply_user", reply_user.username, type: "user")
add_automation_field("max_post_tokens", 100)
end
Expand Down Expand Up @@ -63,7 +65,7 @@ def add_automation_field(name, value, type: "text")
expect(topic.tags.pluck(:name)).to contain_exactly("aaa", "bbb")
expect(topic.visible).to eq(false)
reply = topic.posts.order(:post_number).last
expect(reply.raw).to eq("Yo this is a reply")
expect(reply.raw).to eq(canned_reply_text)
expect(reply.user.id).to eq(reply_user.id)

ai_log = AiApiAuditLog.order("id desc").first
Expand All @@ -79,6 +81,30 @@ def add_automation_field(name, value, type: "text")
expect(count).to be > (50)
end

it "does not triage PMs by default" do
post = Fabricate(:post, topic: personal_message)
automation.running_in_background!
automation.trigger!({ "post" => post })

# nothing should happen, no classification, its a PM
end

it "will triage PMs if automation allows it" do
# needs to be admin or it will not be able to just step in to
# PM
reply_user.update!(admin: true)
add_automation_field("include_personal_messages", true, type: :boolean)
post = Fabricate(:post, topic: personal_message)

DiscourseAi::Completions::Llm.with_prepared_responses(["bad"]) do
automation.running_in_background!
automation.trigger!({ "post" => post })
end

last_post = post.topic.reload.posts.order(:post_number).last
expect(last_post.raw).to eq(canned_reply_text)
end

it "does not reply to the canned_reply_user" do
post = Fabricate(:post, user: reply_user)

Expand Down