DEV: Refactor DeprecationCollector and expand deprecation ID handling
#86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `DEPRECATION_WORKFLOW` usage in `DeprecationCollector` with the `DeprecationWorkflow` module and removed unused `#configById` map for a cleaner implementation. Enhanced the `discourse_deprecation_ids.yml` file to include native array extension deprecations.
tyb-talks
reviewed
Aug 27, 2025
tyb-talks
approved these changes
Aug 27, 2025
Introduce fallback behavior in `DeprecationCollector` to support older versions of core where `DeprecationWorkflow.shouldSilence` is undefined. A temporary `#configById` map is used to handle silenced deprecations until version `v3.6.0.beta2-dev`. Includes TODOs for cleanup post-update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
DEPRECATION_WORKFLOWusage inDeprecationCollectorwith theDeprecationWorkflowmodule and removed unused#configByIdmap for a cleaner implementation and enhanced thediscourse_deprecation_ids.ymlfile to include native array extension deprecations.Requires discourse/discourse#34394