UX: add the user's intent as a query parameter #10
+48
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract the `DiscourseLoginClientStrategy` into its own file - Remove default methods from the `DiscourseLoginClientAuthenticator`
pmusaraj
reviewed
May 15, 2025
|
@pmusaraj fixed the specs and addressed the comments 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to let the provider know whether the user wants to "sign up" or "log in", we added a new
intentquery parameter as one of theauthorize_paramsso the provider can decide which UI to display to the user.DEV: Extract the
DiscourseLoginClientStrategyinto its own fileDEV: Remove default methods from the
DiscourseLoginClientAuthenticatorInternal ref - t/151488