Skip to content

FIX: automatically skip create confirm when plugin is enabled #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

FIX: automatically skip create confirm when plugin is enabled #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,15 @@
enabled_site_setting :discourse_login_client_enabled

auth_provider icon: "fab-discourse", authenticator: DiscourseLoginClientAuthenticator.new

after_initialize do
on_enabled_change do |_, enabled|
if enabled
SiteSetting.set(:auth_skip_create_confirm, true)
SiteSetting.hidden_settings_provider.add_hidden(:auth_skip_create_confirm)
else
SiteSetting.set(:auth_skip_create_confirm, false)
SiteSetting.hidden_settings_provider.remove_hidden(:auth_skip_create_confirm)
end
end
end
19 changes: 19 additions & 0 deletions spec/lib/site_settings_override_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# frozen_string_literal: true

require "rails_helper"

describe "SiteSetting" do
it "overrides auth_skip_create_confirm only when the plugin is enabled" do
expect(SiteSetting.auth_skip_create_confirm).to eq(false)

SiteSetting.discourse_login_client_enabled = true

expect(SiteSetting.auth_skip_create_confirm).to eq(true)
expect(SiteSetting.hidden_settings).to include(:auth_skip_create_confirm)

SiteSetting.discourse_login_client_enabled = false

expect(SiteSetting.auth_skip_create_confirm).to eq(false)
expect(SiteSetting.hidden_settings).not_to include(:auth_skip_create_confirm)
end
end
Loading