Skip to content

UX: Show a "Continue with Discourse ID" button #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ZogStriP
Copy link
Member

@ZogStriP ZogStriP commented May 27, 2025

...instead of the usual Login / Sign Up button to visitors.

Internal ref - t/154881


BEFORE

Screenshot 2025-05-27 at 16 05 52

AFTER

Screenshot 2025-05-27 at 16 05 00

...instead of the usual Login / Sign Up button to visitors.

Internal ref - t/154881
@ZogStriP ZogStriP requested a review from pmusaraj May 27, 2025 10:59
@ZogStriP
Copy link
Member Author

@derekrushforth would love some exploration of how this could look like on mobile (smaller viewports) 🤔

@pmusaraj
Copy link
Contributor

In a strange way, this button is both bigger and less visible, even on desktop. As noted internally, I don't think this is a better CTA than "Log In". Very tricky stuff.

@ZogStriP
Copy link
Member Author

this button is both bigger and less visible, even on desktop.

That's because I took the screenshot before I applied the btn-primary class 🤦

But yeah, it's quite big 🤔

Copy link
Member

@keegangeorge keegangeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions, but otherwise LGTM

Co-authored-by: Keegan George <kgeorge13@gmail.com>
@ZogStriP ZogStriP closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants