Skip to content

A11Y: improve expand/collapse labeling on embedded solution post #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

A11Y: improve expand/collapse labeling on embedded solution post #381

merged 1 commit into from
Jul 10, 2025

Conversation

awesomerobot
Copy link
Member

This adds an aria-label based on the state of the button and also moves the title to the button rather than the icon.

image image

I also noticed that aria-expanded was rendering as aria-expanded="" which isn't helpful, we need a true/false string as the examples show here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-expanded

@awesomerobot awesomerobot merged commit 0f03ec4 into main Jul 10, 2025
6 checks passed
@awesomerobot awesomerobot deleted the a11y-expand-collapse branch July 10, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heymarkreeves heymarkreeves heymarkreeves approved these changes

@CvX CvX CvX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awesomerobot @heymarkreeves @CvX