Skip to content

Remove incorrect CONTENT_TYPE header from GET and HEAD requests #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2013
Merged

Remove incorrect CONTENT_TYPE header from GET and HEAD requests #1270

merged 1 commit into from
Jun 14, 2013

Conversation

tomchristie
Copy link
Member

No description provided.

@tomchristie
Copy link
Member Author

Corresponding ticket: https://code.djangoproject.com/ticket/20596

@mjtamlyn
Copy link
Member

Can you please give us a reference to a document which says this is wrong? I understand that it isn't necessary, but I can't obviously find anything which says it's "incorrect".

@mjtamlyn
Copy link
Member

In fact, this seems to imply that it is not an error. http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.17

@tomchristie
Copy link
Member Author

The section you're referencing is talking about using the Content-Type as it applies to the response of a GET or HEAD request.

@tomchristie
Copy link
Member Author

Can you please give us a reference to a document which says this is wrong?

RFC2616, as you referenced notes, 'the media type of the entity-body'. There is no entity-body, and the usage of content-type there is incorrect.

@mjtamlyn
Copy link
Member

Yup, I've done some more research and it looks ok to me.

mjtamlyn added a commit that referenced this pull request Jun 14, 2013
@mjtamlyn
Merge pull request #1270 from tomchristie/remove-incorrect-content-ty…
0f3f88e 
…pe-test-client

Remove incorrect CONTENT_TYPE header from GET and HEAD requests
@mjtamlyn mjtamlyn merged commit 0f3f88e into django:master Jun 14, 2013
@tomchristie tomchristie deleted the remove-incorrect-content-type-test-client branch June 14, 2013 08:57
@tomchristie
Copy link
Member Author

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomchristie @mjtamlyn