Refs #31223 -- Added __class_getitem__() to ForeignKey #15571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
approved these changes
Apr 22, 2022
ngnpope
added a commit
to ngnpope/django-stubs
that referenced
this pull request
Jul 4, 2022
This matches the change coming in Django 4.1. See django/django#15571
sobolevn
pushed a commit
to typeddjango/django-stubs
that referenced
this pull request
Jul 5, 2022
* Add generic monkeypatching for `FileProxyMixin`. This fixes `TypeError: 'type' object is not subscriptable` for `django.core.files.File` and `django.core.files.base.ContentFile`. * Add generic monkeypatching for `ForeignKey`. This matches the change coming in Django 4.1. See django/django#15571
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful especially for models.ForeignKey('self'). I'm not sure if
django-stubswould use them, butdjango-typeswould use them:https://pypi.org/project/django-types/
ticket-31223