Skip to content

Refs #33620 -- Accessibility in pipeline #16115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sabderemane
Copy link
Member

@sabderemane sabderemane commented Sep 25, 2022

POC CI Accessibility via pa11y combined to axe.

This will add the accessibility github action workflow to the current CI pipeline. There are accessibility errors but the workflow doesn't block the CI for any pull requests. It's using knyghty/django-admin-demo to be able to test the admin properly.

ticket-33620

@sabderemane sabderemane force-pushed the poc-ci-accessibility branch 3 times, most recently from c26a00a to 79aa68e Compare June 1, 2023 12:04
@thibaudcolas
Copy link
Member

thibaudcolas commented Jan 11, 2024

I can’t get this to work :( I’ve been experimenting with this in https://github.com/thibaudcolas/django-django-fork. Can get the setup to work in local dev but not in CI.

Edit: Sarah looking for additional support.

@sabderemane sabderemane force-pushed the poc-ci-accessibility branch from a232a6d to 776d6d5 Compare June 9, 2024 22:51
@sabderemane
Copy link
Member Author

sabderemane commented Jun 9, 2024

@django/accessibility I made it work 🎉
Last attempt seems to work: https://github.com/django/django/actions/runs/9440163808/job/25999124468#step:10:1

Next steps for me:

  • Define the list of pages that the accessibility team want to run under pa11y
  • Have the pipeline non blocking until we fix all the issues
  • Use a pa11y config (optional)
  • Use @knyghty 's demo if possible

@sabderemane sabderemane force-pushed the poc-ci-accessibility branch from 25f6fa5 to bd69bd6 Compare June 9, 2024 23:12
@sabderemane sabderemane force-pushed the poc-ci-accessibility branch 4 times, most recently from f700656 to 7e94800 Compare July 13, 2024 14:42
@sabderemane sabderemane force-pushed the poc-ci-accessibility branch 2 times, most recently from 77a5ad3 to 8754439 Compare April 28, 2025 00:44
@sabderemane sabderemane changed the title Poc ci accessibility Refs #33620 -- Accessibility in pipeline Apr 28, 2025
@sabderemane sabderemane marked this pull request as ready for review April 28, 2025 00:47
@sabderemane sabderemane force-pushed the poc-ci-accessibility branch 6 times, most recently from 04d84bd to 08f4a7d Compare April 28, 2025 09:32
@sabderemane
Copy link
Member Author

@thibaudcolas there is one thing I'm unsure:
pa11y is currently working but only on one url, I didn't managed to make it run on other urls.

Do you have an idea to fix this? OR should I use:

@sabderemane sabderemane requested a review from a team May 22, 2025 11:11
@sarahboyce sarahboyce force-pushed the poc-ci-accessibility branch from 08f4a7d to ddf8fc7 Compare August 8, 2025 12:12
@sarahboyce
Copy link
Contributor

one thing I'm unsure: pa11y is currently working but only on one url, I didn't managed to make it run on other urls.

Do you have an idea to fix this? OR should I use:

* playwright?

* try again pa11y-ci ?

* do a[ pa11y test in javascript](https://github.com/pa11y/pa11y/blob/main/example/multiple/index.js)?

Hello @sabderemane, I was looking into this a bit today.
I think this only runs on a couple of URLs because all the other urls require authentication. So perhaps you want to use selenium or playwright to login and extract the authenticated session cookie (sessionid) and then pass that to the pa11y call 🤔
Also note that knyghty/django-admin-demo already has a superuser set up and stored in db.sqlite3, it might be possible to store a "never expiring" session for that admin user to then use in CI

I don't know what is the best approach here but I hope that helps 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants