Skip to content

Fixed #35892 -- Supported Widget.use_fieldset in admin forms #18803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed #35892 -- Supported Widget.use_fieldset in admin forms #18803

wants to merge 2 commits into from

Conversation

sai-ganesh-03
Copy link
Contributor

@sai-ganesh-03 sai-ganesh-03 commented Nov 13, 2024 •
edited
Loading

Trac ticket number

ticket-35892

Branch description

Supported Widget.use_fieldset in admin forms

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

sarahboyce
sarahboyce reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing tests and updates to the template to respect this attribute
Please set "Patch needs improvement" on this ticket to "No" when this is ready to be reviewed

@sarahboyce sarahboyce added selenium Apply to have Selenium tests run on a PR screenshots 🖼️ labels Nov 14, 2024
@nessita nessita changed the title Supported Widget.use_fieldset in admin forms Fixed #35892 -- Supported Widget.use_fieldset in admin forms Nov 25, 2024
timgraham
timgraham reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@timgraham timgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template changes also need to be tested.

django/contrib/admin/widgets.py
@@ -50,6 +50,7 @@ def get_context(self, name, value, attrs):


class BaseAdminDateWidget(forms.DateInput):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these unrelated newline additions.

@Antoliny0919 Antoliny0919 mentioned this pull request Jul 27, 2025
Open
6 tasks
@sarahboyce
Copy link
Contributor

Superseded by #19678

@sarahboyce sarahboyce closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgraham timgraham timgraham left review comments

@sarahboyce sarahboyce Awaiting requested review from sarahboyce

Assignees
No one assigned
Labels
screenshots 🖼️ selenium Apply to have Selenium tests run on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai-ganesh-03 @sarahboyce @timgraham