Fixed #36410 -- Added named template partials to DTL #19643

FarhanAliRaza · 2025-07-16T10:13:09Z

Updated get_template in Django template backend to load a partial template
Added partialdef and partial template tags
Added documentation for the partials tags
Added tests for the partial tags

Trac ticket number

ticket-36410

Branch description

Provide a concise overview of the issue or rationale behind the proposed changes.

Checklist

This PR targets the main branch.
The commit message is written in past tense, mentions the ticket number, and ends with a period.
I have checked the "Has patch" ticket flag in the Trac system.
I have added or updated relevant tests.
I have added or updated relevant docs, including release notes if applicable.
I have attached screenshots in both light and dark modes for any UI changes.

nessita

Hello @FarhanAliRaza, amazing start! 🌟

Thank you for working on this. I have added a first round of initial comments. Let me know if you have any questions.

Looking forward to seeing this progressing!

docs/releases/6.0.txt

tests/template_tests/templates/partial_examples.html

django/template/backends/django.py

docs/ref/templates/builtins.txt

tests/template_tests/test_partials.py

django/template/defaulttags.py

FarhanAliRaza · 2025-07-18T16:19:00Z

Thanks for the review.
Exciting times ahead. I will start fixing these things as soon as possible.

nessita

@FarhanAliRaza Thank you for the round of fixes, I appreciate the quick turnaround!

I added some more comments, specifically around tests we should use a bit more of subTest, but this is looking great overall.

Then, there is an outstanding design question about where best to place the "template proxy". I like Carlton's suggestions and I have added a few more notes. Also I'm looking forward of @ngnpope input!

Once all the above is resolved, I will do a top-bottom final review to ensure consistency and live testing to check correctness.

tests/template_tests/test_partials.py

django/template/backends/django.py

django/test/utils.py

django/template/defaulttags.py

carltongibson · 2025-07-22T06:51:20Z

@nessita I don't know why GitHub is not showing it on the main Conversations tab, but I replied to your #19643 (comment), and it does show in the Files view.

FarhanAliRaza · 2025-07-22T12:22:11Z

Extra review points are fixed. Now, I'm just waiting for the code-moving bit to be finalized.

nessita · 2025-07-23T01:47:43Z

@nessita I don't know why GitHub is not showing it on the main Conversations tab, but I replied to your #19643 (comment), and it does show in the Files view.

Thank you for pointing that out, I commented in the same thread.

nessita

Astonishing progress, thank you @FarhanAliRaza and @carltongibson!

django/template/backends/django.py

django/template/defaulttags.py

django/test/utils.py

django/template/defaulttags.py

FarhanAliRaza · 2025-07-23T15:49:33Z

Added syntax tests. Refactored tests to match other syntax tests like include tests.
Moved TemplateProxy to base.py and renamed it to PartialTemplate.
Moved SubDictionaryWrapper to utils.py

nessita · 2025-07-30T01:37:36Z

Added syntax tests. Refactored tests to match other syntax tests like include tests. Moved TemplateProxy to base.py and renamed it to PartialTemplate. Moved SubDictionaryWrapper to utils.py

Thank you @FarhanAliRaza for the updates, I'll be restarting work/review on this PR tomorrow morning.

nessita · 2025-07-30T01:38:12Z

@ngnpope Hello! Is this PR something you wanted/could take a look? Non worries if not, but let me know when you can.

nessita

I've been doing a deep dive on tests, both the unit and manual tests.

I'll push some tweaks, along with some cleanup, including a squash of all commits. I'm also spent an embarrassing amount of time trying to replace the current mock-heavy test_partial_template_get_exception_info with a test that would be more realistic (more on that below). This has lead to the following potential bug discovery.

Local setup

Basic Django project with a testapp app and testapp/urls.py that include:

    path("partialtest/", TemplateView.as_view(template_name="partialtest.html")),

partialtest.html looks like this:

<h1>Title</h1>

{% partialdef testtestest %}
    <p>{{ nonexistent|default:"alsonotthere" }}</p>
{% endpartialdef %}

<h2>Sub Title</h2>
{% partial testtestest %}

Bug?

Should path("partialtestpartial/", TemplateView.as_view(template_name="partialtest.html#testestest")) work? Currently is crashes with traceback:

Internal Server Error: /testapp/partialtestpartial/
Traceback (most recent call last):
  File "/home/nessita/fellowship/django/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/home/nessita/fellowship/django/django/core/handlers/base.py", line 221, in _get_response
    response = response.render()
  File "/home/nessita/fellowship/django/django/template/response.py", line 114, in render
    self.content = self.rendered_content
                   ^^^^^^^^^^^^^^^^^^^^^
  File "/home/nessita/fellowship/django/django/template/response.py", line 90, in rendered_content
    template = self.resolve_template(self.template_name)
  File "/home/nessita/fellowship/django/django/template/response.py", line 72, in resolve_template
    return select_template(template, using=self.using)
  File "/home/nessita/fellowship/django/django/template/loader.py", line 47, in select_template
    raise TemplateDoesNotExist(", ".join(template_name_list), chain=chain)
django.template.exceptions.TemplateDoesNotExist: partialtest.html#testestest
[30/Jul/2025 19:24:50] "GET /testapp/partialtestpartial/ HTTP/1.1" 500 87799

If we change "alsonotthere" with alsonotthere (i.e. make the literal string a missing var in the context), IRL we get the expected exception VariableDoesNotExist and I see PartialTemplate.get_exception_info being called. But I tried to model a test after this and is close but it needs tweaks to fully mimic a real scenario, could you take a look and see what's missing?

from django.template import Context, Engine, Template, VariableDoesNotExist
from django.template.base import Token, TokenType
from django.test import SimpleTestCase, override_settings


class TemplateExceptionInfoTests(SimpleTestCase):

    @override_settings(DEBUG=True)
    def test_get_exception_info_reports_correct_location_locmem(self):
        buggy_template = """<h1>Title</h1>
{% partialdef testtestest %}
    <p>{{ nonexistent|default:alsonotthere }}</p>
{% endpartialdef %}
<h2>Sub Title</h2>
{% partial testtestest %}
"""
        engine = Engine(
            loaders=[
                ("django.template.loaders.locmem.Loader", {"template": buggy_template}),
            ]
        )
        # This does NOT trigger PartialTemplate.get_exception_info AND has an origin.
        template = engine.get_template("template")

        # This DOES trigger PartialTemplate.get_exception_info, but it has NO origin.
        template = Template(buggy_template, origin=template.origin)
        try:
            template.render(Context({}))
        except VariableDoesNotExist as e:
            # Simulate token from the failed parse.
            fake_token = Token(
                token_type=TokenType.VAR,
                contents="nonexistent|default:alsonotthere",
                position=(10, len(buggy_template)),
            )
            exc_info = template.get_exception_info(e, token=fake_token)

        # exc_info has the same content whether `PartialTemplate.get_exception_info`
        # returns something or {}!
        self.assertEqual(exc_info.get("message"), "Failed lookup for key [%s] in %r")

I need to stop for now but as said I will some changes so please pull them before making any further changes. Thanks! 🌟

carltongibson · 2025-07-30T19:00:18Z

@nessita I don't know if this is the issue but, the partial name in the url is testestest :

path("partialtestpartial/", TemplateView.as_view(template_name="partialtest.html#testestest"))

But the partial in the template is testtestest:

{% partialdef testtestest %}

There's an extra t in the latter one, which would explain the template not found exception.

nessita · 2025-07-30T19:12:45Z

@nessita I don't know if this is the issue but, the partial name in the url is testestest :

path("partialtestpartial/", TemplateView.as_view(template_name="partialtest.html#testestest"))

But the partial in the template is testtestest:

{% partialdef testtestest %}

There's an extra t in the latter one, which would explain the template not found exception.

Thank you for looking so quickly, that was a typo (caused by one of the manual testing stages to test an undefined partial name). I've swicthed to partialtest for clarity and I still get:

Exception Type: TemplateDoesNotExist at /testapp/partialtestpartial/
Exception Value: partialtest.html#partialtest

Template:

<h1>Title</h1>

{% partialdef partialtest %}
    <p>{{ nonexistent|default:alsonotthere }}</p>
{% endpartialdef %}

<h2>Sub Title</h2>
{% partial partialtest %}

carltongibson · 2025-07-30T19:25:12Z

@FarhanAliRaza See if you can reproduce.

Against template-partials (at b6adac3) I get:

TemplateNotFound for a missing partial name: #not-a-partial say. (Expected)
alsonotthere output for {{ nonexistent|default:"alsonotthere" }} (Expected)
VariableDoesNotExist for {{ nonexistent|default:alsonotthere }} (I guess we're saying Expected right? — Didn't think about it fully, but going by what Natalia said.)

I didn't test this branch, but if that's not what we're seeing a difference snuck in, that we'll need to pin down.

carltongibson · 2025-07-30T19:44:44Z

I didn't test this branch, ...

OK, I tested. I can't reproduce this @nessita. With the "alsonotthere" version, I get the expected output in the browser.

natalia.zip

nessita · 2025-07-30T20:33:18Z

I didn't test this branch, ...

OK, I tested. I can't reproduce this @nessita. With the "alsonotthere" version, I get the expected output in the browser.

Thank you! I'll debug more tomorrow, will start from scratch with your project.

nessita · 2025-07-30T23:23:35Z

I didn't test this branch, ...

OK, I tested. I can't reproduce this @nessita. With the "alsonotthere" version, I get the expected output in the browser.

Thank you! I'll debug more tomorrow, will start from scratch with your project.

I can confirm this works, as Carlton pointed out. I have just now tested with a bunch of prints removed, I wonder if that was causing the issues I saw before 🤔

As a side note, and not related to this branch nor to the issue above, a print of exception as the first statement in get_exception_info generates a max recursion error when there is an exception in a template. This is informational since it was very hard to pin point!

@FarhanAliRaza I guess that one thing that would be useful for me is if you could take a look at the test trying to test more realistically PartialTemplate.get_exception_info to, if possible, drop the current mocks.

FarhanAliRaza · 2025-07-31T12:39:25Z

@FarhanAliRaza See if you can reproduce.

@carltongibson I can not reproduce it. Working as expected.

TemplateNotFound for a missing partial name: #not-a-partial say. (Expected)

alsonotthere
output for
{{ nonexistent|default:"alsonotthere" }}
(Expected) VariableDoesNotExist for
{{ nonexistent|default:alsonotthere }}
(I guess we're saying Expected right? — Didn't >think about it fully, but going by what Natalia said.)

The same applies to me for this current branch.

@nessita Working on the test case.

FarhanAliRaza · 2025-07-31T15:11:28Z

@nessita I have added tests for get_exception_info by using the template_debug that I believe is the output of the get_exception_info

with self.assertRaises(VariableDoesNotExist) as cm:
            template.render(context)

exc_info = cm.exception.template_debug

nessita · 2025-07-31T15:25:25Z

@nessita I have added tests for get_exception_info by using the template_debug that I believe is the output of the get_exception_info
with self.assertRaises(VariableDoesNotExist) as cm:
            template.render(context)

exc_info = cm.exception.template_debug

Thank you! I can't look right away because I'm deep in other review, but could you please double check that if the implementation for PartialTemplate.get_exception_info would get changed to return {}, the proper test fail with meaningful information?

FarhanAliRaza · 2025-07-31T15:57:09Z

@nessita

Yes, I made sure it gave KeyError
Should I add asserts to provide more descriptive errors?

ERROR: test_partial_runtime_error_exception_info (template_tests.syntax_tests.test_partials.PartialTagTests.test_partial_runtime_error_exception_info)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/farhan/code/django/tests/template_tests/syntax_tests/test_partials.py", line 448, in test_partial_runtime_error_exception_info
    self.assertIn("badsimpletag", exc_debug["during"])
                                  ~~~~~~~~~^^^^^^^^^^
KeyError: 'during'

======================================================================
ERROR: test_partial_runtime_exception_has_debug_info (template_tests.syntax_tests.test_partials.PartialTagTests.test_partial_runtime_exception_has_debug_info)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/farhan/code/django/tests/template_tests/syntax_tests/test_partials.py", line 303, in test_partial_runtime_exception_has_debug_info
    self.assertEqual(exc_info["during"], "{{ nonexistent|default:alsonotthere }}")
                     ~~~~~~~~^^^^^^^^^^
KeyError: 'during'

======================================================================
FAIL: test_partial_template_get_exception_info_delegation (template_tests.syntax_tests.test_partials.PartialTagTests.test_partial_template_get_exception_info_delegation)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/farhan/code/django/tests/template_tests/syntax_tests/test_partials.py", line 335, in test_partial_template_get_exception_info_delegation
    self.assertIn("message", exc_info)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'message' not found in {}

----------------------------------------------------------------------
Ran 25 tests in 0.016s

ngnpope

Hey @carltongibson and @nessita. I managed to do a review this evening - hope it helps. This is shaping up to be very nice and feels like it'll provide a lot of power with very little code to implement it - thanks for your efforts @FarhanAliRaza! 🥇

django/template/backends/django.py

django/template/base.py

docs/ref/templates/language.txt

docs/ref/templates/api.txt

docs/ref/templates/language.txt

django/template/defaulttags.py

django/template/utils.py

FarhanAliRaza · 2025-08-01T19:31:01Z

Implemented the suggestion from @ngnpope .
Handled nested partials handling by updating find_partial_source to use a single regex and handle search in nested case.
Refactored SubDictionaryWrapper to move error handling out of it to RenderPartialNode
and moved it to django/utils/datastructures.py
And other refactors.

carltongibson · 2025-08-06T18:30:22Z

@FarhanAliRaza @nessita on the new-features repo there's a suggestion to move _render() and render() into a common base mixin, that we might want to pick up here?

nessita

Thank you @FarhanAliRaza! This is shaping nicely and with a delight precision. 🌟

Today I focused mostly on the new syntax tests. Overall I would like to see more meaningful names used for the tests and the templates, and also more of subTest when semantically adequate. I added some suggestions for both of these points.

Then, a minor nitpick: I think that the partial name used for testing could be partial-name or testing-name to signal clearly to readers that this is a name identifier.

Thinking about performance, we may need one or two tests with big chunky templates (using html test files) making heavy use of the new tags to see if the regexes show any obvious catastrophic side-effect.

tests/template_tests/syntax_tests/test_partials.py

django/template/base.py

nessita · 2025-08-06T19:18:43Z

django/template/base.py

+    def _render(self, context):
+        return self.nodelist.render(context)


I think we are missing some tests or something else is going on. If I change this code to be this instead:

Suggested change

def _render(self, context):

return self.nodelist.render(context)

def _render(self, context):

return ""

No test fails. I'm sure there is a reasonable explanation but I can't find it :-).

nessita · 2025-08-11T20:23:59Z

Thinking about performance, we may need one or two tests with big chunky templates (using html test files) making heavy use of the new tags to see if the regexes show any obvious catastrophic side-effect.

What do you have in mind here @nessita? (Im struggling to imagine the kind of case you want to look at.)

I'll try to think of a concrete example and I'll share here.

The regex is just used for the debug view right, fetching the source. Is there a DoS vector there? 🤔

Good point, while going deep in the review vertical I lost track of this detail. Can you help me understand which flow exactly triggers this code path?

…plate Language. Introduced `{% partialdef %}` and `{% partial %}` template tags to define and render reusable named fragments within a template file. Partials can also be accessed using the `template_name#partial_name` syntax via `get_template()`, `render()`, `{% include %}`, and other template-loading tools. Adjusted `get_template()` behavior to support partial resolution, with appropriate error handling for invalid names and edge cases. Introduced `PartialTemplate` to encapsulate partial rendering behavior. Includes tests and internal refactors to support partial context binding, exception reporting, and tag validation. Co-authored-by: Carlton Gibson <carlton@noumenal.es> Co-authored-by: Natalia <124304+nessita@users.noreply.github.com> Co-authored-by: Nick Pope <nick@nickpope.me.uk>

nessita

@FarhanAliRaza Thank you for the steady and great work on this PR! 🌟

I went thru "tests vertical" today. I've pushed some cleanups, including two tests that are now commented out because they are failing. The tests are the ones below and I think using the {% include 'partial_included.html#included-partial' %} should work, right?

    @setup(
        {
            "partial_as_include_in_other_template": (
                "MAIN TEMPLATE START\n"
                "{% include 'partial_included.html#included-partial' %}\n"
                "MAIN TEMPLATE END"
            )
        },
        partial_templates,
    )
    def _test_partial_as_include_in_template(self):
        # XXX: Needs fixing?
        output = self.engine.render_to_string("partial_as_include_in_other_template")
        expected = (
            "MAIN TEMPLATE START\n"
            "THIS IS CONTENT FROM THE INCLUDED PARTIAL\n"
            "MAIN TEMPLATE END"
        )
        self.assertEqual(output, expected)

    @setup(
        {
            "nested_simple": (
                "{% extends 'base.html' %}"
                "{% block content %}"
                "This is my main page."
                "{% partialdef outer inline %}"
                "    It hosts a couple of partials."
                "    {% partialdef inner inline %}"
                "        And an inner one."
                "    {% endpartialdef inner %}"
                "{% endpartialdef outer %}"
                "{% endblock content %}"
            ),
            "use_outer": "{% include 'nested_simple#outer' %}",
            "use_inner": "{% include 'nested_simple#inner' %}",
        }
    )
    def _test_nested_partials(self):
        # XXX: Needs fixing?
        with self.subTest(template_name="use_outer"):
            output = self.engine.render_to_string("use_outer")
            self.assertEqual(output, "It hosts a couple of partials. And an inner one.")
        with self.subTest(template_name="use_inner"):
            output = self.engine.render_to_string("use_inner")
            self.assertEqual(output, "And an inner one.")

@carltongibson do you think I'm missing something? I double checked and I don't have local changes that could be messing things up. I have errors such as:

django.template.exceptions.TemplateDoesNotExist: partial_included.html#included-partial

FarhanAliRaza · 2025-08-12T04:31:25Z

The tests are the ones below and using the {% include 'partial_included.html#included-partial' %} should work, right?

I think when the include tag is used, it tries to load using the base Engine instance, which does not use Django Template Backend

Some options that I can think of to fix this are to change

Engine.get_template method to make it aware of partials.

Change the loading logic in the Include tag to somehow load using the django backend.

carltongibson · 2025-08-12T05:12:07Z

@FarhanAliRaza The examples from those tests work standardly. I use that pattern a lot. Wondering if it's a test artifact? 🤔

The base Engine.get_template goes via the loader, which traverses the backends to find the correct template. This still goes via the Django backend, which is partial aware.

carltongibson · 2025-08-12T05:24:45Z

I'm not seeing the failure here locally. eb8c218
eed7f44 passes. The CI run looks to have passed too (the two failures look unrelated).

FarhanAliRaza · 2025-08-12T05:26:40Z

@carltongibson
I ll retest.

I'm not seeing the failure here locally. eb8c218

The first time that happened to me, too. Can you check if that specific test is running because it has _ in front of it? So it did not run for me for first try.

carltongibson · 2025-08-12T05:32:10Z

The first time that happened to me, too. Can you check if that specific test is running because it has _ in front of it? So it did not run for me for first try.

Thanks. Got it.

carltongibson · 2025-08-12T05:54:15Z

@FarhanAliRaza Yep, so you're bang on. It's that the @setup helper is using the base Engine directly, rather than the DjangoTemplates backend (and then each backend, Django/Jinja/..., extends Engine).

We setup the loaders on Engine to use locmem and then it has no awareness of partials. Hence the error.

Engine.get_template method to make it aware of partials.

I don't think that's right: Partials are being added to the Django Backend, not the backend agnostic template functionality per se.

Change the loading logic in the Include tag to somehow load using the django backend.

No, include is fine. It's the test that's at fault here.

I think we just need to not use the setup helper here, and test the Django backend itself (which works).

Update:

Engine.get_template method to make it aware of partials.

I guess we could create a mini Engine subclass just with the necessary change for the setup helper to use. It would only need to pull off the fragment, call the super implementation, and then check for the partial at the end. (As the loader does in template-partials.)

Personally I'd rewrite the test but 🤷

FarhanAliRaza · 2025-08-12T05:59:46Z

I tried without @setup decorator also .
It gives the same error .
I changed the test to load using template files using filesystem loader and also by creating custom django backend in the test function, it still fails.

Because in include the loading happens through context.template loading that somehow does not use the Django backend. I am not sure how exactly but I added print statement loading during include, it does not Django backend for that.

carltongibson · 2025-08-12T06:07:02Z

@FarhanAliRaza Can you push your rewritten test?

This pattern...

         "MAIN TEMPLATE START\n"
          "{% include 'partial_included.html#included-partial' %}\n"
          "MAIN TEMPLATE END"

... has been working since the package was created.

We've had tests on that since ≈ day one no? Suddenly there's a failure: it's unlikely to now need a change to include. (It's a test artefact is first suspect.)

django/template/base.py

Co-authored-by: Carlton Gibson <carlton@noumenal.es>

FarhanAliRaza · 2025-08-12T06:43:58Z

I only tested the usage of partial inside the included HTML file. Not tested partial loading like this {% include 'partial_included.html#included-partial' %} that is failing now.

only tested this about include

@setup(
        {
            "partial_with_include": (
                "MAIN TEMPLATE START\n"
                "{% include 'partial_included.html' %}\n"
                "MAIN TEMPLATE END"
            )
        },
        partial_templates,
    )
    def test_partial_in_included_template(self):
        output = self.engine.render_to_string("partial_with_include")
        expected = (
            "MAIN TEMPLATE START\nINCLUDED TEMPLATE START\n\n\n"
            "Now using the partial: \n"
            "THIS IS CONTENT FROM THE INCLUDED PARTIAL\n\n\n"
            "INCLUDED TEMPLATE END\n\nMAIN TEMPLATE END"
        )
        self.assertEqual(output, expected)

FarhanAliRaza · 2025-08-12T07:07:49Z

test.zip
experimental project.

FarhanAliRaza · 2025-08-12T07:31:36Z

This solution works if we change the loading in the include tag.

Another method is refactoring get_template.

 diff --git a/django/template/loader_tags.py b/django/template/loader_tags.py
  index 3a0d054e62..4e76f1a44c 100644
  --- a/django/template/loader_tags.py
  +++ b/django/template/loader_tags.py
  @@ -4,6 +4,7 @@ from collections import defaultdict
   from django.utils.safestring import mark_safe

   from .base import Node, Template, TemplateSyntaxError, TextNode, Variable,
  token_kwargs
  +from .exceptions import TemplateDoesNotExist
   from .library import Library

   register = Library()
  @@ -197,7 +198,31 @@ class IncludeNode(Node):
               cache = context.render_context.dicts[0].setdefault(self, {})
               template = cache.get(template_name)
               if template is None:
  -                template = context.template.engine.select_template(template_name)
  +                partial_template = None
  +                for name in template_name:
  +                    if "#" in name:
  +                        base_name, _, partial_name = name.partition("#")
  +                        try:
  +                            base_template = context.template.engine.get_template(
  +                                base_name
  +                            )
  +                            extra_data = getattr(base_template, "extra_data", {})
  +                            if (
  +                                "template-partials" in extra_data
  +                                and partial_name in 
  extra_data["template-partials"]
  +                            ):
  +                                partial_template = 
  extra_data["template-partials"][
  +                                    partial_name
  +                                ]
  +                                partial_template.engine = context.template.engine
  +                                break
  +                        except TemplateDoesNotExist:
  +                            continue
  +
  +                if partial_template:
  +                    template = partial_template
  +                else:
  +                    template = 
  context.template.engine.select_template(template_name)
                   cache[template_name] = template
           # Use the base.Template of a backends.django.Template.
           elif hasattr(template, "template"):

carltongibson · 2025-08-12T08:39:33Z

OK, we've just inserted the partial lookup in the wrong place. Confusing names strike again. django.template.backends.base.BaseEngine is what everything subclasses. django.template.engine.Engine is Django specific — so not a problem adjusting it — and where the partial lookup needs to live.

@FarhanAliRaza If you restore django/template/backends/django.py and implement the logic there in django/template/engine.py we'll be in the right place, I think.

(When migrating the partial lookup logic from the loader in template-partials, we've moved it up two levels to the backend, rather than just one to engine. Pushing it down again will give us what was intended.)

nessita · 2025-08-12T12:11:32Z

@FarhanAliRaza Can you push your rewritten test?

This pattern...
         "MAIN TEMPLATE START\n"
          "{% include 'partial_included.html#included-partial' %}\n"
          "MAIN TEMPLATE END"
... has been working since the package was created.

We've had tests on that since ≈ day one no?

Since I started reviewing, I did not see a test for this specific case. I think we may have missed it since the start (at least in this PR, unsure about template-partials).

Suddenly there's a failure: it's unlikely to now need a change to include. (It's a test artefact is first suspect.)

A little bit more of info around this: I added the tests because the include wasn't working for me in a real (test) project. Amazing that you both could debugged it so quickly!

carltongibson · 2025-08-12T13:42:32Z

... unsure about template-partials

It turned out not. Well, except in my work project of course. 😅 Since the loader (where it's implemented in template-partials) is inside the engine it works. The issue here was we'd move the logic outside the engine, which meant it only worked via the usual public API, but not via the reference to the engine that the include tag uses.

nessita · 2025-08-12T14:45:10Z

django.template.backends.base.BaseEngine is what everything subclasses. django.template.engine.Engine is Django specific — so not a problem adjusting it — and where the partial lookup needs to live.

To double check that we are in the same page, let me share what I think this means:

Revert changes to django/template/backends/django.py.
Extend the implementation of Engine.get_template to detect partials and try to server them when possible.

Is that correct?

…kend . refactored tests to match new refactoring. Added more tests.

FarhanAliRaza · 2025-08-12T15:06:54Z

Moved get_template partial implementation from DjangoTemplates.get_template to Engine.get_template. Added tests that @nessita suggested. Thank you, it was a great find.

Fixed test mocks for the new implementation.

FarhanAliRaza force-pushed the template-partials branch from 1fb9159 to 0c95342 Compare July 17, 2025 09:25

nessita requested changes Jul 18, 2025

View reviewed changes

carltongibson reviewed Jul 18, 2025

View reviewed changes

django/template/defaulttags.py Outdated Show resolved Hide resolved

carltongibson reviewed Jul 18, 2025

View reviewed changes

django/template/defaulttags.py Outdated Show resolved Hide resolved

nessita reviewed Jul 21, 2025

View reviewed changes

nessita reviewed Jul 23, 2025

View reviewed changes

django/template/backends/django.py Outdated Show resolved Hide resolved

django/template/defaulttags.py Outdated Show resolved Hide resolved

django/test/utils.py Outdated Show resolved Hide resolved

django/template/defaulttags.py Outdated Show resolved Hide resolved

nessita reviewed Jul 30, 2025

View reviewed changes

nessita force-pushed the template-partials branch from a7a6263 to 16804e4 Compare July 30, 2025 18:55

nessita force-pushed the template-partials branch from 16804e4 to 0024ea2 Compare July 30, 2025 19:21

ngnpope reviewed Jul 31, 2025

View reviewed changes

nessita reviewed Aug 6, 2025

View reviewed changes

nessita force-pushed the template-partials branch 2 times, most recently from 4ad61a0 to 264fc67 Compare August 11, 2025 18:30

nessita force-pushed the template-partials branch from 264fc67 to 44c2bbd Compare August 11, 2025 20:25

nessita force-pushed the template-partials branch from 44c2bbd to eb8c218 Compare August 11, 2025 20:29

nessita reviewed Aug 11, 2025

View reviewed changes

carltongibson reviewed Aug 12, 2025

View reviewed changes

django/template/base.py Outdated Show resolved Hide resolved

FarhanAliRaza and others added 2 commits August 12, 2025 11:38

Update django/template/base.py

d841abc

Co-authored-by: Carlton Gibson <carlton@noumenal.es>

added experimental tests

1908d31

FarhanAliRaza added 2 commits August 12, 2025 12:38

experimental fix for include tempalte loading.

d60a75b

test refactor

31cb5c5

Refactored template handling to Engine.get_template from django bac…

3ee1f69

…kend . refactored tests to match new refactoring. Added more tests.

reverted include tag experiment

7f96792

		def _render(self, context):
		return self.nodelist.render(context)

Uh oh!

Fixed #36410 -- Added named template partials to DTL #19643

Are you sure you want to change the base?

Fixed #36410 -- Added named template partials to DTL #19643

Conversation

FarhanAliRaza commented Jul 16, 2025

Trac ticket number

Branch description

Checklist

Uh oh!

nessita left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FarhanAliRaza commented Jul 18, 2025

Uh oh!

nessita left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carltongibson commented Jul 22, 2025

Uh oh!

FarhanAliRaza commented Jul 22, 2025

Uh oh!

nessita commented Jul 23, 2025

Uh oh!

nessita left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FarhanAliRaza commented Jul 23, 2025

Uh oh!

nessita commented Jul 30, 2025

Uh oh!

nessita commented Jul 30, 2025

Uh oh!

nessita left a comment

Choose a reason for hiding this comment

Local setup

Bug?

Uh oh!

carltongibson commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nessita commented Jul 30, 2025

Uh oh!

carltongibson commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carltongibson commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nessita commented Jul 30, 2025

Uh oh!

nessita commented Jul 30, 2025

Uh oh!

FarhanAliRaza commented Jul 31, 2025

carltongibson commented Jul 30, 2025 •

edited

Loading

carltongibson commented Jul 30, 2025 •

edited

Loading

carltongibson commented Jul 30, 2025 •

edited

Loading

FarhanAliRaza commented Aug 12, 2025 •

edited

Loading

carltongibson commented Aug 12, 2025 •

edited

Loading

FarhanAliRaza commented Aug 12, 2025 •

edited

Loading