Skip to content

Refs #36005 -- Bumped minimum supported versions of docutils to 0.22. #19686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Jul 30, 2025

This bumps minimum supported version of docutils to the first release to support Python 3.12.

Follow up to d9af197.

@nessita
Copy link
Contributor

nessita commented Jul 30, 2025

@felixxm this is causing issues for me when using a Python 3.13 venv. Installing all dependencies from scratch gives this error:

ERROR: Cannot install -r docs/requirements.txt (line 2), docutils>=0.22 and sphinx==8.2.3 because these package versions have conflicting dependencies.

Seems that Sphinx is not ready for docutils 0.22+ yet, see Sphinx changelog:

Release 8.3.0 (in development)
#13786: Support Docutils 0.22. Patch by Adam Turner.

I think we may need to pin docutils to < 0.22 instead, like Sphinx does:

"docutils>=0.20,<0.22",

@nessita
Copy link
Contributor

nessita commented Jul 30, 2025

I see this is caused by installing both the docs/requirements.txt and tests/requirements/py3.txt in the same env, which I usually do for Django development. Are you using two separated envs for docs vs tests? 🤔

@felixxm
Copy link
Member Author

felixxm commented Jul 30, 2025

I see this is caused by installing both the docs/requirements.txt and tests/requirements/py3.txt in the same env, which I usually do for Django development. Are you using two separated envs for docs vs tests? 🤔

We've bumped requirements for Django (django.contrib.admindocs). I don't think that lack of Sphinx support should block this, but we can wait a bit. Sphinx 8.3.0 will support the newest docutils version.

@nessita
Copy link
Contributor

nessita commented Jul 31, 2025

I see this is caused by installing both the docs/requirements.txt and tests/requirements/py3.txt in the same env, which I usually do for Django development. Are you using two separated envs for docs vs tests? 🤔

We've bumped requirements for Django (django.contrib.admindocs). I don't think that lack of Sphinx support should block this, but we can wait a bit. Sphinx 8.3.0 will support the newest docutils version.

Makes sense, thank you, I'll approve so you can land when you consider it best.

Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This bumps minimum supported versions of 3rd-party packages to the first
releases to support Python 3.12.

Follow up to d9af197.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants