Refs #28643 -- Added Repeat database function. #9808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37014cb to
8653ab3
Compare
|
Failures on MySQL are not related with this PR, it returns wrong results also for other functions, e.g. |
|
It turns out that |
|
Looks good, pending the MySQL issue. |
ngnpope
approved these changes
Mar 22, 2018
django/db/backends/sqlite3/base.py
Outdated
| @@ -170,6 +170,7 @@ def get_new_connection(self, conn_params): | |||
| conn.create_function("django_format_dtdelta", 3, _sqlite_format_dtdelta) | |||
| conn.create_function("django_power", 2, _sqlite_power) | |||
| conn.create_function('LPAD', 3, _sqlite_lpad) | |||
| conn.create_function('REPEAT', 2, _sqlite_repeat) | |||
There was a problem hiding this comment.
I'd make this a lambda or use operator.mul.
|
I added the separate ticket 29251 for the MySQL issue. |
timgraham
approved these changes
Apr 3, 2018
tests/db_functions/test_repeat.py
Outdated
| authors = Author.objects.annotate(repeated_text=function) | ||
| self.assertQuerysetEqual(authors, [repeated_text], lambda a: a.repeated_text, ordered=False) | ||
|
|
||
| def test_repeat_negative_number(self): |
tests/db_functions/test_repeat.py
Outdated
|
|
||
|
|
||
| class RepeatTests(TestCase): | ||
| def test_repeat(self): |
Thanks Tim Graham and Nick Pope for reviews.
|
@timgraham Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/28643