Skip to content

Add precommit #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add precommit #1185

wants to merge 4 commits into from

Conversation

pauloxnet
Copy link
Member

No description provided.

@felixxm
Copy link
Member

felixxm commented Jul 22, 2022

@pauloxnet Thanks for this patch 👍 However, IMO we don't need most of this hooks. It's not really worth to optimize svg files, edits vendor libraries, or auto-generated migration files.

@pauloxnet
Copy link
Member Author

I think that the end-file lines have been added to the SVG files or others file or trailing-spaces have been removed.

I use these hooks in all my repositories, but tell me what you think it is not good to add for this project that I remove them from the precommit file:
https://github.com/pauloxnet/djangoproject.com/blob/feature/precommit/.pre-commit-config.yaml

@pauloxnet
Copy link
Member Author

Close in favor of #1198

@pauloxnet pauloxnet closed this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants