Clean tox config #2134
Clean tox config #2134
Conversation
Already handled by pre-commit
Already handled by pre-commit
Already handled by pre-commit
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the tox configuration by removing redundant code quality tools (black, flake8, and isort) that are already handled by pre-commit, and introduces a dedicated GitHub Actions workflow for pre-commit checks. The changes streamline the CI pipeline by eliminating duplication between tox and pre-commit tooling.
- Removed black, flake8, and isort environments from tox configuration
- Added a new GitHub Actions workflow specifically for pre-commit checks
- Updated documentation to reflect the simplified testing approach
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Removed black, flake8, and isort test environments and dependencies |
| requirements/dev.txt | Removed isort dependency as it's now handled by pre-commit |
| README.rst | Updated documentation to remove reference to flake8 in testing description |
| Makefile | Removed isort and isort-check targets |
| .github/workflows/pre-commit.yml | Added new GitHub Actions workflow for running pre-commit checks |
There was a problem hiding this comment.
I haven't been able to test this, but the proposed changes appear to make sense.
Regarding the use of pre-commit.ci, I personally don't have any preferences. I'd say do whatever works best. As you wrote, nothing is set in stone and if things don't work out we can always revert.
Nice work! 🧹
Relates to #1890
Removes black, flake8, and isort from tox config. All of them are already handled by pre-commit.
About the new action;
I am a bit hesitant about using https://pre-commit.ci/ for pre-commit checks, for several reasons:
My vote here would be to disable that integration and continue with the action. I can revert the new action if the consensus is to not change it, but I wanted to include it because the cleaning in the PR makes the CI more dependent on pre-commit.