Remove debug print from apphook_reload #6917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinalAngel
approved these changes
Oct 8, 2020
|
@FinalAngel @Aiky30 could you restart the failed travis task? failure seem more random than related to this, and apparentyl I can't restart tasks on travis (probably due to the org change) |
|
@yakky @FinalAngel I don't have the access to rerun this test I'm afraid. I don't think I was ever able to in Travis, I could in Circle CI. |
|
@FinalAngel forced a push to retrigger the build. I confirm that I can now cancel / retry builds on travis |
Aiky30
approved these changes
Oct 28, 2020
|
Needs bringing up to date and then it's ready to come in. |
Remove print statements from apphook_reload.py Debug logging in the codebase via print statements is OK locally, but should never have been committed to the codebase.
|
@Aiky30 sorry I missed your comment Changelog entry added |
Aiky30
approved these changes
Dec 8, 2020
|
@Aiky30 conflict fixed |
merwok
reviewed
Dec 8, 2020
Co-authored-by: Éric Araujo <merwok@netwok.org>
fsbraun
pushed a commit
to fsbraun/django-cms
that referenced
this pull request
Jun 2, 2023
Debug logging in the codebase via print statements is OK locally, but should never have been committed to the codebase. Co-authored-by: Stuart Axon <stuaxo2@yahoo.com> Co-authored-by: Éric Araujo <merwok@netwok.org> Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
fsbraun
added a commit
that referenced
this pull request
Jun 2, 2023
…7572) * Update wizards.py (typo fix) * add eslint exception for new-cap * fix eslint error * Update test * Dynamic unihan decoder selection based on page language * Fix: Unicode slug for v4 * Use Slug field in page admin form for slug * Remove print statements from apphook_reload.py (#6917) Debug logging in the codebase via print statements is OK locally, but should never have been committed to the codebase. Co-authored-by: Stuart Axon <stuaxo2@yahoo.com> Co-authored-by: Éric Araujo <merwok@netwok.org> Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com> * Update forms * Fix log entry test * fix json linting * Update tests for django 2.2 * ... and fix ruff issue --------- Co-authored-by: Iacopo Spalletti <github@spalletti.it> Co-authored-by: Stuart Axon <stuaxo2@yahoo.com> Co-authored-by: Éric Araujo <merwok@netwok.org> Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port changes in #6791 as aggreed on the issue
Related resources
Checklist
develop