Skip to content

fix: Remove can_publish permission from django CMS 4 core #7635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Aug 25, 2023

Description

While looking at #7633 I realized that the can_publish permission still is in the django CMS 4 core code base (#7634).
This PR removes it and fixes tests so that they work without the can_publish permission.

This pull request is draft, since upon clarification I would like to add changes that resolve #7633.

Related resources

Checklist

  • I have opened this pull request against release/4.1.x (to integrate with other migrations generated by the release)
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested review from marksweb and Aiky30 August 25, 2023 07:22
@marksweb marksweb marked this pull request as ready for review September 3, 2023 15:29
@marksweb
Copy link
Member

marksweb commented Sep 3, 2023

Didn't mean to take out of draft 😬

@fsbraun fsbraun merged commit 807a87b into django-cms:release/4.1.x Oct 16, 2023
fsbraun added a commit to fsbraun/django-cms that referenced this pull request Oct 18, 2023
…ms#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss
fsbraun added a commit that referenced this pull request Oct 24, 2023
* Fix: `.load` jQuery method erroneously replaced by `on('load')`

* fix: Remove `can_publish` permission from django CMS 4 core (#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss

* Fix: Use svg icons for boolean values in admin (present since Dango 1.11)

* Fix: Update to use .format for icon base

* Fix: missing alt attribute
@fsbraun fsbraun deleted the fix/remove_publish_permission branch November 30, 2023 16:37
fsbraun added a commit that referenced this pull request Dec 10, 2023
* ci: Merge back `release/4.1.x` (4.1.0rc4) into `develop-4` (#7640)

* Fix: Debug toolbar action button has too low contrast in dark mode (#7642)

* feat: django 5 support (#7648)

* Support for Django 5.0

* Fix: test.yml and django Promise handling

* Shorten github action names

* Update test.yml

* Update _cms.scss

* Update setup.py

* test: Run tests against django main branch (#7650)

* ci: Add testing against django main branch

* ci: Add dependabot github action updates

* ci: Test all dbs on django main

* Update postgres

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* Output django version

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* Output django version

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* ci: install requirements before django

* Remove duplicate

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* Replace get_storage_class with import_string

* Fix ruff

* remove unused code from util. __init__.py

* Fix incomplete property overwrite

* Fix: Lazy choice field implementation was wrong. Added test coverage

* Fix: Add `on-error-continue: true` to django-main-postgres and django-main-mysql github actions

---------

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* fix: When opening structure board page menu disappears or shows wrong page template (#7671)

* Fix: add .current_page to request for structure board

* Fix caching issue showing wrong selected page template

* Fix: add .current_page to request for structure board

* Fix caching issue showing wrong selected page template

* Add tests

* fix: Update RTD config (#7647)

* Add comments

---------

Co-authored-by: Mark Walker <mark@django-cms.org>

* fix: #7662, add support for python 3.12 and upgrade github actions (#7680)

* fix: #7662, add support for python 3.12 and upgrade github actions

* fix: deprecations

* fix: make some improvements to codespell and the tests for docs

* fix: add updated reqs for docs

* fix: code spell typos

* fix: code spell typos for docs

* fix: some more spell fixes

* fix: pretty much all spelling mistakes

* fix: some more spelling mistakes

* fix: skiplist further

* fix: issue with outdated deps at docs/requirements

* fix: downgrade matplotlib to a version that also builds on python 3.8

* fix: 3.8 build

* fix: try to fix some test failures

* fix: drop 3.8

* fix: upgrade sphinxcontrib-spelling to 8.0.0 so that 3.12 builds

* fix: no need to hardcode sphinx in test requirements

* fix: get the tests passing for sqlite

* fix: sqlite tests finally

* fix: use furo theme for cms 4 as well

:

* fix: use cms 4 for building docs documentation

* fix: same as in develop for cms 3.11.x

* fix: abbreviation into full form to not confused codespell

* fix: `.load` jQuery method erroneously replaced by `.on('load')` (#7679)

* Fix: `.load` jQuery method erroneously replaced by `on('load')`

* fix: Remove `can_publish` permission from django CMS 4 core (#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss

* Fix: Use svg icons for boolean values in admin (present since Dango 1.11)

* Fix: Update to use .format for icon base

* Fix: missing alt attribute

* fix: Port forward #7664 and #7657 (#7695)

* fix: preserve `view_class` in decorated views (#7664)

* Fix tests

* Bugfix: avoid InvalidCacheKey (memcached) for key-length ~249 (fixes #7595) (#7657)

* Remove docs test from test suite (since covered by separate github action)

* Remove docs requirements from the django-main test

* Add setuptools to requirements for python 3.12

* Add setuptools to requirements.txt

* Fix: Test with current ckeditor

* Undo unnecessary change

* Fix tests for Django 5.1

* Fix: Missing output_field

---------

Co-authored-by: Will Hoey <48737592+Will-Hoey@users.noreply.github.com>
Co-authored-by: wfehr <24782511+wfehr@users.noreply.github.com>

* fix: validate endpoint languages and redirect if not editable (#7691)

* Fix: align language settings for preview and edit endpoints

* Rename to existing "is_editable" method.

* Add "object_is_editable" to toolbar as a common interface to decide if an object is editable

* Fix identation

* fix: Add check for Django's i18n context processor needed for wizards to work (#7699)

* Check for `django.template.context_processors.i18n` preprocessor in the i18n check (required for wizards to work)

* Fix tests ;-)

* feat: Add `djangocms` command to quickly start a project (#7702)

* fix: Localization of permission checks on deleting (#7683)

* Permission in the german version have sometimes german names.

* change django-cms to cms

* Remove specific German locale test

* Update pageadmin.py

* Undo renaming

---------

Co-authored-by: wintergruen <dirk.wintergruen@klassik-stiftung.de>
Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* fix: django 5's choice widget is not lazy (#7707)

* Support for Django 5.0

* Fix: test.yml and django Promise handling

* Shorten github action names

* Update test.yml

* Update _cms.scss

* Update setup.py

* Fix: Django 5 choice widget is not lazy either

* Add test

* Fix: Swapped underscore

* Deprecate SuperLazyIterator and LazyChoiceField

* fix: Page Content Extension toolbar (#7708)

* Fix: page content extension toolbar naming and use latest_content filter

* Align page content extension menu with shown page content

* Deprecate the use for more than one page content object

* fix linting issue

* Accommodate review feedback

* Add some comments

* Readability improvement `ruff format`

* One more readability improvement

* Doc-string update

* Fix typo

Co-authored-by: Jacob Rief <jacob.rief@gmail.com>

* fix: Language chooser options pointing to the same language (#7698)

* Fix: Language chooser

* Ensure page language uniqueness

* Fix linter issue

* Add edit mode and preview mode to language chooser

* Add option to register grouper field for frontend-editable models

* Undo changes to cms_toolbars to avoid code redundancy

* Simplify toolbar utils.

* Remove not util function

* Remove unneeded imports

* fix: allow for `EmptyPageContent`

* Add CONTRIBUTING.rst and CODE_OF_CONDUCT.rst to develop-4 branch (#7713)

---------

Co-authored-by: Mark Walker <mark@django-cms.org>
Co-authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Co-authored-by: Will Hoey <48737592+Will-Hoey@users.noreply.github.com>
Co-authored-by: wfehr <24782511+wfehr@users.noreply.github.com>
Co-authored-by: dwintergruen <dwinter@comp-hum.de>
Co-authored-by: wintergruen <dirk.wintergruen@klassik-stiftung.de>
Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
fsbraun added a commit that referenced this pull request Jan 5, 2024
* Fix: modal.scss dark-mode compatibilitiy

* Add: Build all assets as part of the frontend test

* fix: Better action feedback

* fix: Update _modal.scss

* fix: Remove publish/draft reference from grouper admin message

* fix ruff

* Add Django 4.2 support to release notes

* Fix transifex-pull-strings

* fix: Update transifex source file (#7629)

* Fix css glitch

* Update translations source fill which was missing strings

* Add migration for page content verbose name

* Fix: Open new plugin window in language of toolbar not of page (#7632)

* Fix: Broken page actions menu if CMS_PERMISSIONS is set

* Build: release 4.1.0rc4 (#7637)

* [4.1.0rc4 release process] Building locales

* [4.1.0rc4 release process] Bumped version to 4.1.0rc4

* [4.1.0rc4 release process] compilemessages

* [4.1.0rc4 release process] compiling new static files

* [4.1.0rc4 release process] updating latest docs

* Update CHANGELOG.rst

* Update 4.1.0.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* fix: en locale in `release/4.1.x` (#7638)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* fix: en locale typo (#7639)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* Fix typo

* Fix: typo: occured -> occurred

* undo mo change

* fix: Remove `can_publish` permission from django CMS 4 core (#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss

* ci: Merge back 4.1.0.rc5 build into release/4.1.x (#7720)

* [4.1.0rc5 release process] Building locales

* [4.1.0rc5 release process] Bumped version to 4.1.0rc5

* [4.1.0rc5 release process] compilemessages

* [4.1.0rc5 release process] compiling new static files

* [4.1.0rc5 release process] updating latest docs

* Create releases.yml

* Update releases.yml

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Update setup.cfg

* Remove py3.8 from setup.cfg

* feat: add v4 docs to main branch (#7722)

* Add docs

* Improve formatting

* Update formatting

* Update changelog for 4.0 from git logs

* Fix typos

* Update docs for frontend testing (#7726)

* fix: Update make-release script to evaluate git diff-index exit codes

* Update make-release to allow for empty messages commit

* chore: Merge `release/build` into `release/4.1.x` (#7729)

* [4.1.0 release process] Bumped version to 4.1.0

* [4.1.0 release process] compilemessages

* [4.1.0 release process] compiling new static files

* [4.1.0 release process] updating latest docs

* Restore 4.0 changelog entries

* fix: Django 5 only allows POST requests to log out (#7728)

* Django 5 only allows POST requests to log out

* Update test

* Update CHANGELOG.rst

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Apply suggestions from code review

* fix: Incomplete command to create a virtual env in docs (#7735)

* docs: Remove reference to rc5 from 01-install.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Co-authored-by: Leonardo Cavallucci <leo.cavallucci@gmail.com>
fsbraun added a commit to fsbraun/django-cms that referenced this pull request Feb 7, 2024
* Fix: modal.scss dark-mode compatibilitiy

* Add: Build all assets as part of the frontend test

* fix: Better action feedback

* fix: Update _modal.scss

* fix: Remove publish/draft reference from grouper admin message

* fix ruff

* Add Django 4.2 support to release notes

* Fix transifex-pull-strings

* fix: Update transifex source file (django-cms#7629)

* Fix css glitch

* Update translations source fill which was missing strings

* Add migration for page content verbose name

* Fix: Open new plugin window in language of toolbar not of page (django-cms#7632)

* Fix: Broken page actions menu if CMS_PERMISSIONS is set

* Build: release 4.1.0rc4 (django-cms#7637)

* [4.1.0rc4 release process] Building locales

* [4.1.0rc4 release process] Bumped version to 4.1.0rc4

* [4.1.0rc4 release process] compilemessages

* [4.1.0rc4 release process] compiling new static files

* [4.1.0rc4 release process] updating latest docs

* Update CHANGELOG.rst

* Update 4.1.0.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* fix: en locale in `release/4.1.x` (django-cms#7638)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* fix: en locale typo (django-cms#7639)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* Fix typo

* Fix: typo: occured -> occurred

* undo mo change

* fix: Remove `can_publish` permission from django CMS 4 core (django-cms#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss

* ci: Merge back 4.1.0.rc5 build into release/4.1.x (django-cms#7720)

* [4.1.0rc5 release process] Building locales

* [4.1.0rc5 release process] Bumped version to 4.1.0rc5

* [4.1.0rc5 release process] compilemessages

* [4.1.0rc5 release process] compiling new static files

* [4.1.0rc5 release process] updating latest docs

* Create releases.yml

* Update releases.yml

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Update setup.cfg

* Remove py3.8 from setup.cfg

* feat: add v4 docs to main branch (django-cms#7722)

* Add docs

* Improve formatting

* Update formatting

* Update changelog for 4.0 from git logs

* Fix typos

* Update docs for frontend testing (django-cms#7726)

* fix: Update make-release script to evaluate git diff-index exit codes

* Update make-release to allow for empty messages commit

* chore: Merge `release/build` into `release/4.1.x` (django-cms#7729)

* [4.1.0 release process] Bumped version to 4.1.0

* [4.1.0 release process] compilemessages

* [4.1.0 release process] compiling new static files

* [4.1.0 release process] updating latest docs

* Restore 4.0 changelog entries

* fix: Django 5 only allows POST requests to log out (django-cms#7728)

* Django 5 only allows POST requests to log out

* Update test

* Update CHANGELOG.rst

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Apply suggestions from code review

* fix: Incomplete command to create a virtual env in docs (django-cms#7735)

* docs: Remove reference to rc5 from 01-install.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Co-authored-by: Leonardo Cavallucci <leo.cavallucci@gmail.com>
marksweb pushed a commit that referenced this pull request Apr 27, 2024
* Fix: modal.scss dark-mode compatibilitiy

* Add: Build all assets as part of the frontend test

* fix: Better action feedback

* fix: Update _modal.scss

* fix: Remove publish/draft reference from grouper admin message

* fix ruff

* Add Django 4.2 support to release notes

* Fix transifex-pull-strings

* fix: Update transifex source file (#7629)

* Fix css glitch

* Update translations source fill which was missing strings

* Add migration for page content verbose name

* Fix: Open new plugin window in language of toolbar not of page (#7632)

* Fix: Broken page actions menu if CMS_PERMISSIONS is set

* Build: release 4.1.0rc4 (#7637)

* [4.1.0rc4 release process] Building locales

* [4.1.0rc4 release process] Bumped version to 4.1.0rc4

* [4.1.0rc4 release process] compilemessages

* [4.1.0rc4 release process] compiling new static files

* [4.1.0rc4 release process] updating latest docs

* Update CHANGELOG.rst

* Update 4.1.0.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* fix: en locale in `release/4.1.x` (#7638)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* fix: en locale typo (#7639)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* Fix typo

* Fix: typo: occured -> occurred

* undo mo change

* fix: Remove `can_publish` permission from django CMS 4 core (#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss

* ci: Merge back 4.1.0.rc5 build into release/4.1.x (#7720)

* [4.1.0rc5 release process] Building locales

* [4.1.0rc5 release process] Bumped version to 4.1.0rc5

* [4.1.0rc5 release process] compilemessages

* [4.1.0rc5 release process] compiling new static files

* [4.1.0rc5 release process] updating latest docs

* Create releases.yml

* Update releases.yml

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Update setup.cfg

* Remove py3.8 from setup.cfg

* feat: add v4 docs to main branch (#7722)

* Add docs

* Improve formatting

* Update formatting

* Update changelog for 4.0 from git logs

* Fix typos

* Update docs for frontend testing (#7726)

* fix: Update make-release script to evaluate git diff-index exit codes

* Update make-release to allow for empty messages commit

* chore: Merge `release/build` into `release/4.1.x` (#7729)

* [4.1.0 release process] Bumped version to 4.1.0

* [4.1.0 release process] compilemessages

* [4.1.0 release process] compiling new static files

* [4.1.0 release process] updating latest docs

* Restore 4.0 changelog entries

* fix: Django 5 only allows POST requests to log out (#7728)

* Django 5 only allows POST requests to log out

* Update test

* Update CHANGELOG.rst

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Apply suggestions from code review

* fix: Incomplete command to create a virtual env in docs (#7735)

* docs: Remove reference to rc5 from 01-install.rst

* fix #7826

* Fix merge errors

* Fix readme links

* Undo unwanted change

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Co-authored-by: Leonardo Cavallucci <leo.cavallucci@gmail.com>
Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants