Skip to content

fix: Correct regression introduced in #7920 (structure board breakpoint) #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 24, 2024
Merged

fix: Correct regression introduced in #7920 (structure board breakpoint) #7928

merged 9 commits into from
May 24, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented May 23, 2024

Description

The PR corrects #7920 which contained an incorrect fix (I committed the wrong out of two options I tested, sorry!)...

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from vinitkumar May 23, 2024 19:47
@fsbraun fsbraun changed the title Fix/structure board breakpoint fix: Correct regression introduced in #7920 (structure board breakpoint) May 23, 2024
fsbraun added a commit that referenced this pull request May 23, 2024
@fsbraun
Add fix of #7928
b1027cd
fsbraun added a commit that referenced this pull request May 24, 2024
@fsbraun @jrief
fix: Backport of #7868 and #7920 (#7926)
d2c2cb5 
* fix: Only switch to structure endpoint on viewport breakpoint if in edit mode (#7920)

* fix: #7859: allow special characters in page title (#7868)

* fix #7859: allow special characters in page title

* Update test_templatetags.py

* Fix ruff issues in test_templatetags.py

* One more time: fix ruff issues in test_templatetags.py

---------

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* Add fix of #7928

* Update cms.structureboard.js

---------

Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
@vinitkumar vinitkumar merged commit 201236a into django-cms:develop-4 May 24, 2024
@fsbraun fsbraun deleted the fix/structure-board-breakpoint branch May 24, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar