Skip to content

fix: PermissionDenied error when adding page #7965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jrief
Copy link
Contributor

@jrief jrief commented Jul 24, 2024

Description

This fixes a regression introduced by the PR merging Page and TreeNode.

Related resources

When adding a subpage to an existing page, django-CMS raised a PermissionDeny-exeption. This was caused by a missing parameter in the form action.

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

This error slipped through the unit tests, because they do not evaluate the action="…" in the rendered HTML. Without E2E-testing this probably is impossible to check.

@jrief jrief changed the title fix PermissionDenied error when adding page fix: PermissionDenied error when adding page Jul 24, 2024
@fsbraun fsbraun merged commit db46e57 into django-cms:develop-4 Jul 24, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants