Skip to content

fix: template tag get_admin_url_for_language did not return the latest page content #7967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 29, 2024
Merged

fix: template tag get_admin_url_for_language did not return the latest page content #7967

merged 5 commits into from
Jul 29, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jul 25, 2024 •
edited
Loading

Description

Solves #7966

The template tag did not „see“ unpublished or archived versions.

This will need to be tested in djangocms-verisoning. I have added a test to django-cms/djangocms-versioning#417 once this is merged and the test can pass.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun
Fix: template tag get_admin_url_for_language should return the late…
1ee0621 
…st page content object for the language (even if unpublished)
@fsbraun fsbraun requested a review from a team July 25, 2024 09:27
@fsbraun fsbraun mentioned this pull request Jul 26, 2024
Merged
4 tasks
@fsbraun fsbraun added the needs to be backported Commits need to be backported label Jul 29, 2024
@fsbraun fsbraun merged commit b4f54a5 into django-cms:develop-4 Jul 29, 2024
32 checks passed
@fsbraun fsbraun deleted the fix/page-settings branch July 29, 2024 20:05
fsbraun added a commit to fsbraun/django-cms that referenced this pull request Oct 20, 2024
@fsbraun
fix: template tag get_admin_url_for_language did not return the lat…
b9782de 
…est page content (django-cms#7967)

* Fix: template tag `get_admin_url_for_language` should return the latest page content object for the language (even if unpublished)

* Fix: correct read-only slug and overwrite url for page settings
@fsbraun fsbraun mentioned this pull request Oct 20, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
needs to be backported Commits need to be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @marksweb