Skip to content

fix: Consistent labels and help texts for page content model and page content forms #7968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 29, 2024
Merged

fix: Consistent labels and help texts for page content model and page content forms #7968

merged 6 commits into from
Aug 29, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jul 26, 2024

Description

The read-only page content form (page settings) fields are rendered by Django and refer to the verbose_name and help_text attributes of the page content's fields.

Those differed from the label and help_text attributes of the forms in cms.admin.forms.

This PR aligns them and improves DRY.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from marksweb July 29, 2024 06:22
@fsbraun fsbraun added the needs to be backported Commits need to be backported label Jul 29, 2024
@fsbraun fsbraun requested a review from a team August 20, 2024 06:45
@fsbraun fsbraun requested a review from vinitkumar August 27, 2024 12:47
vinitkumar
vinitkumar approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@fsbraun fsbraun merged commit 5f2f9e4 into django-cms:develop-4 Aug 29, 2024
32 checks passed
@fsbraun fsbraun deleted the fix/page-settings-form branch August 29, 2024 13:57
fsbraun added a commit that referenced this pull request Aug 29, 2024
@fsbraun
Fix: Consistent labels and help texts for page content model and page…
acbc2e7 
… content forms (#7968)

Co-authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

@marksweb marksweb Awaiting requested review from marksweb

Assignees
No one assigned
Labels
needs to be backported Commits need to be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar