Skip to content

fix: edit_mode_active was a property, not cached property #7971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: edit_mode_active was a property, not cached property #7971

merged 1 commit into from
Jul 29, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jul 29, 2024

Description

Replacing a cached property by a property in a subclass leads to side-effects.

This PR fixes a regression introduced in #7850 which leads to djangocms-versioning tests to fail.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from marksweb July 29, 2024 16:02
marksweb
marksweb approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fsbraun fsbraun merged commit 93f6fc5 into django-cms:develop-4 Jul 29, 2024
34 checks passed
@fsbraun fsbraun deleted the fix/property-regression branch January 10, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @marksweb