Skip to content

fix: Consistent toolbar mode #8011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Sep 25, 2024

Description

#7850 introduced a regression which affects populating the toolbar in structure mode. This fix restores consistent toolbar modes:

  • preview
  • edit
  • structure (always also edit)

The regression allowed the toolbar to be in structure mode and edit mode leading to some buttons being populated twice.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from a team September 25, 2024 08:04
@fsbraun fsbraun added the 5.0 label Sep 25, 2024
@fsbraun fsbraun merged commit 1f864af into django-cms:develop-4 Sep 27, 2024
50 of 51 checks passed
@fsbraun fsbraun deleted the fix/structure-toolbar branch May 16, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants