Skip to content

fix: Accept legacy action names for page permission check #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Oct 3, 2024

Description

Some 3rd party apps use outdated action names for checking page permissions. This PR adds those names.

Fixes #8020 for v4

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from a team October 3, 2024 19:51
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@fsbraun fsbraun merged commit 9a1e178 into django-cms:develop-4 Oct 5, 2024
48 of 51 checks passed
@fsbraun fsbraun deleted the fix/legacy-permissions branch October 5, 2024 08:38
fsbraun pushed a commit that referenced this pull request Oct 5, 2024
fsbraun added a commit that referenced this pull request Oct 7, 2024
* [4.1.3 release process] Building locales

* [4.1.3 release process] Bumped version to 4.1.3

* [4.1.3 release process] compilemessages

* [4.1.3 release process] compiling new static files

* [4.1.3 release process] updating latest docs

* Update CHANGELOG.rst

* Update 4.1.3.rst

* Update 4.1.3.rst

* chore: Django 5.2-compatible test fixtures (#8008)

* chore: Re-hook fixture loading to stay compatible with django 5.2

* Remove Postgres pin to v12 for testing

* Exclude Py39 from dj51

* Pin postgres to version 15

* Switch from psycopg2 to recommended psycopg>=3.1.8

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Update CHANGELOG.rst typo

* chore: Backport #8021

* fix: Update databases.txt to include psycopg2 for Django < 4.2

* fix: Mark language and user middleware synchronous for ASGI (Backport of #7986)

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]3.11.8 version has cms:permissions error 'keyerror'
2 participants