fix: Sitemap: Return a QuerySet in CMSSitemap.items() #8031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Django docs a sequence like a list is allowed for the return value of CMSSitemap.items() but djangocms-page-sitemap applies exclude, which only works with querysets. In django CMS 3.11 it was a QuerySet. In django CMS 4 the return value changed to a list, though, which breaks djangocms-page-sitemap.
So the next commit becomes more readable.
fsbraun
approved these changes
Oct 14, 2024
|
Fixes #8029 |
fsbraun
added a commit
that referenced
this pull request
Oct 16, 2024
* fix: Sitemap: Don’t convert QuerySet to list in CMSSitemap.items() According to the Django docs a sequence like a list is allowed for the return value of CMSSitemap.items() but djangocms-page-sitemap applies exclude, which only works with querysets. In django CMS 3.11 it was a QuerySet. In django CMS 4 the return value changed to a list, though, which breaks djangocms-page-sitemap. * style: Format cms/tests/test_sitemap.py with ruff So the next commit becomes more readable. * test: Add test for type of CMSSitemap.items() --------- Co-authored-by: Fabian Braun <fsbraun@gmx.de>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the Django docs also a sequence like a list is allowed as the return value type of CMSSitemap.items(),
but djangocms_page_sitemap applies exclude, which only works with
QuerySet.This PR changes the type of the return value back to
QuerySet.Related resources
Checklist
develop-4