Skip to content

fix: Sites menu was empty in the page tree #8064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 6, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Nov 5, 2024

Description

Fixes #8063

(Adds a query to the page tree to get the sites.)

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from vinitkumar November 5, 2024 15:30
@fsbraun fsbraun added the needs to be backported Commits need to be backported label Nov 5, 2024
@fsbraun fsbraun added the 5.0 label Nov 5, 2024
@fsbraun fsbraun merged commit d4b811d into django-cms:develop-4 Nov 6, 2024
51 checks passed
@fsbraun fsbraun deleted the fix/missing-sites branch November 6, 2024 20:06
fsbraun added a commit to fsbraun/django-cms that referenced this pull request Nov 6, 2024
* Update make-release.yml

* Update make-release.yml

* Update make-release.yml

* Update make-release.yml

* Update make-release.yml

* Update make-release

* Update make-release

* fix: `tree.sites` was missing from the page tree context

* Undo unwante dchanges

* More undo

---------

Co-authored-by: Vinit Kumar <mail@vinitkumar.me>
fsbraun added a commit that referenced this pull request Nov 6, 2024
* Update make-release.yml

* Update make-release.yml

* Update make-release.yml

* Update make-release.yml

* Update make-release.yml

* Update make-release

* Update make-release

* fix: `tree.sites` was missing from the page tree context

* Undo unwante dchanges

* More undo

---------

Co-authored-by: Vinit Kumar <mail@vinitkumar.me>
@fsbraun fsbraun added 4.1 and removed needs to be backported Commits need to be backported labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sites not in pageadmin context. Dropdown for Sites is empty.
2 participants