Skip to content

Updated frontend bundles to include the fixes #8106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2025
Merged

Updated frontend bundles to include the fixes #8106

merged 2 commits into from
Jan 10, 2025

Conversation

sgordeychuk
Copy link

@sgordeychuk sgordeychuk commented Jan 9, 2025 •
edited by sourcery-ai bot
Loading

Description

While debugging the fix for the missing structure mode button in the django CMS 4.0.1.x I found that static files were not built correctly by Kobe because the fix is not there. I've checked it on a clean CMS installation and it only works with the version of this commit (KCuppens@13a93e1) when the bundles were correct. In the release build of dev5 the bundle is incorrect and doesn't have the "missing structure button" fix.

I've regenerated the static files by running gulp bundle and updated the version and now the fix is working correctly.

Please let me know if I need to add any other info.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Update frontend bundles to version 4.0.1.dev6, including the fix for the missing structure mode button.

Bug Fixes:

  • Fixed the missing structure mode button in django CMS 4.0.1.x.

Build:

  • Regenerated static files using gulp bundle.

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jan 9, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the frontend bundles to include necessary fixes for a missing structure mode button in django CMS 4.0.1.x. The static files were regenerated by running gulp bundle, and the version was updated to reflect these changes.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated frontend bundles
  • Regenerated static files using gulp bundle
  • Updated version number
 cms/static/cms/sass/components/_iconography.scss
cms/static/cms/css/4.0.1.dev5/cms.base.css
cms/static/cms/css/4.0.1.dev5/cms.pagetree.css
cms/static/cms/css/4.0.1.dev5/cms.welcome.css
cms/static/cms/js/dist/4.0.1.dev5/bundle.admin.base.min.js
cms/static/cms/js/dist/4.0.1.dev5/bundle.toolbar.min.js
cms/__init__.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sgordeychuk - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sgordeychuk
Copy link
Author

Hi @fsbraun

Could you please take a look and let me know if everything is good?
I've made a branch from release/4.0.1.x because it has to be that branch for a specific customer on Divio.

@fsbraun
Copy link
Member

fsbraun commented Jan 9, 2025

@sgordeychuk The bundles are only rebuilt when a release is generated as @joshyu mentioned #7970 (comment).

Generally, the release process does also include an update of the docs, translations, changelog, etc. It's entirely up to you to decide when to release.

The only request I have is an update of the changelog. This would need to include all changes since the last release(s).

Here's what I see (but you'll need to check):

@sgordeychuk
Copy link
Author

Thanks for the info @fsbraun !

You've listed almost everything "released" in the last commits in the 4.0.1.x branch. It's a bit difficult here because 4.0.1 version is not officially released so changelog looks weird. I was mostly using the last changelog items and tracked down other changes in git after the last line there.

@fsbraun fsbraun merged commit 0170a00 into django-cms:release/4.0.1.x Jan 10, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgordeychuk @fsbraun