Skip to content

fix: Remove more text decorations in page tree introduced by django 5.2 #8219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 7, 2025
Merged

fix: Remove more text decorations in page tree introduced by django 5.2 #8219

merged 7 commits into from
May 7, 2025

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented May 6, 2025 •
edited
Loading

Description

Extends #8214 and also removes decorators from drop-down menus and versioning menu.

Related resources

Checklist

  • I have opened this pull request against main
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Remove unwanted text decorations in Django admin page tree and dropdown menus

Bug Fixes:

  • Removed unintended text decorations introduced by Django 5.2 in page tree and dropdown menus

Enhancements:

  • Updated CSS selectors to remove link decorations with higher specificity

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented May 6, 2025 •
edited
Loading

Reviewer's Guide

This pull request updates CSS styles to remove text decorations from links in the page tree, its drop-down menus, and the versioning menu. This is achieved by introducing more specific CSS rules in cms.admin.scss and _tree.scss to override default Django 5.2 admin styles that add text decorations.

File-Level Changes

Change Details Files
Removed text decorations from links in page tree and related menus.
  • Added new CSS rules with higher specificity to set text-decoration: none for anchor tags within the page tree, dropdown menus, and versioning menu.
  • Ensured link button styles override default Django admin link decorations by repeating classes in selectors where necessary for increased specificity (e.g., a.btn.btn).
 cms/static/cms/sass/cms.admin.scss
cms/static/cms/sass/components/pagetree/_tree.scss
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fsbraun - I've reviewed your changes - here's some feedback:

  • Repeating class names in selectors like .btn.btn or .cms-pagetree.cms-pagetree.cms-pagetree boosts specificity but can hinder readability; consider if alternative selector structures could achieve the same.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

vinitkumar
vinitkumar approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@vinitkumar vinitkumar merged commit 7f8a6e3 into develop-4 May 7, 2025
67 checks passed
@fsbraun fsbraun added the needs to be backported Commits need to be backported label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
needs to be backported Commits need to be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar