chore: Merge back django CMS 5.0.0 build #8220

fsbraun · 2025-05-08T07:09:53Z

Description

At testing I had to fix two more bugs:

Plugins that require a parent were not shown in the plugin selector box (omg) - a missing parameter at the plugin_pool.registered_plugins property.
The plugin pool accessed the page cache without need at project startup

This is read to go from my side.

Related resources

#...
#...

Checklist

I have opened this pull request against main
I have added or modified the tests when changing logic
I have followed the conventional commits guidelines to add meaningful information into the changelog
I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Merge back django CMS 5.0.0 build, updating version and font references from 5.0.0a1 to 5.0.0

New Features:

Updated to final 5.0.0 version

Chores:

Updated font and icon references from 5.0.0a1 to 5.0.0
Updated static CSS and JavaScript files to 5.0.0 version

Summary by Sourcery

Update project assets and configuration to reflect the django CMS 5.0.0 release, including static files, versioning, and compatibility updates.

Enhancements:

Update static asset references and versioning from 5.0.0a1 to 5.0.0.

Build:

Add new CSS files for 5.0.0 and remove obsolete 5.0.0a1 assets.

CI:

Update CI workflow to test against Python 3.13 and Django 5.2.

Documentation:

Update documentation and upgrade guides for the 5.0.0 release.

Tests:

Adjust tests to align with plugin pool and cache changes.

sourcery-ai · 2025-05-08T07:09:58Z

Reviewer's Guide

This PR merges back the django CMS 5.0.0 build, finalizing the version upgrade from 5.0.0a1 to 5.0.0, updating static assets, font references, and code to reflect the final release, and cleaning up legacy or debug code.

File-Level Changes

Change	Details	Files
Update version and static asset references from 5.0.0a1 to 5.0.0.	Bump version to 5.0.0. Update font-face and static asset paths in SCSS and CSS files to use 5.0.0. Replace static CSS/JS files for 5.0.0a1 with 5.0.0 versions. Remove 5.0.0a1 static files and add 5.0.0 equivalents.	`cms/__init__.py` `cms/static/cms/sass/components/_iconography.scss` `cms/static/cms/css/5.0.0/cms.admin.css` `cms/static/cms/css/5.0.0/cms.base.css` `cms/static/cms/css/5.0.0/cms.welcome.css` `cms/static/cms/js/dist/5.0.0a1/bundle.admin.base.min.js` `cms/static/cms/css/5.0.0a1/cms.admin.css` `cms/static/cms/css/5.0.0a1/cms.base.css` `cms/static/cms/css/5.0.0a1/cms.pagetree.css` `cms/static/cms/css/5.0.0a1/cms.welcome.css` `cms/static/cms/js/dist/5.0.0a1/bundle.toolbar.min.js`
Update plugin pool and cache handling logic for plugin discovery and cache invalidation.	Remove legacy cache invalidation from plugin discovery. Update registered_plugins property to use new plugin retrieval logic. Simplify test for cache invalidation and plugin pool reset.	`cms/plugin_pool.py` `cms/tests/test_cache.py`
Remove debug and print statements from tests.	Remove print statements from test_templatetags.py.	`cms/tests/test_templatetags.py`
Update CI workflow and test matrix for new Python and Django versions.	Add Django 5.2 and Python 3.13 to test matrix in GitHub Actions workflow.	`.github/workflows/test_startcmsproject.yml`
Documentation and translation updates for 5.0.0 release.	Update changelog and upgrade documentation for 5.0.0. Add/adjust upgrade docs for previous 4.1.x releases. Update translation files.	`CHANGELOG.rst` `docs/upgrade/5.0.0.rst` `docs/upgrade/index.rst` `docs/upgrade/version.rst.template` `docs/upgrade/4.1.2.rst` `docs/upgrade/4.1.3.rst` `docs/upgrade/4.1.4.rst` `docs/upgrade/4.1.5.rst` `docs/upgrade/4.1.6.rst` `cms/locale/en/LC_MESSAGES/django.po` `cms/locale/zh_CN/LC_MESSAGES/django.po`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @fsbraun - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟡 General issues: 17 issues found
🟢 Security: all looks good
🟡 Testing: 1 issue found
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

cms/tests/test_cache.py

CHANGELOG.rst

docs/upgrade/4.1.4.rst

docs/upgrade/4.1.2.rst

docs/upgrade/4.1.3.rst

docs/upgrade/4.1.6.rst

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

docs/upgrade/4.1.2.rst

Github Release Action and others added 7 commits May 7, 2025 07:36

[5.0.0 release process] Building locales

26570d2

[5.0.0 release process] Bumped version to 5.0.0

3d6ba7c

[5.0.0 release process] compilemessages

5ebc663

[5.0.0 release process] compiling new static files

3013c3e

[5.0.0 release process] updating latest docs

154c6f6

fix: Changlog and plugin pool

deb3dc3

chore: Update start project test to py3.13

beb8650

Merge branch 'develop-4' into release/build

3c9d135

fsbraun temporarily deployed to test May 9, 2025 05:53 — with GitHub Actions Inactive

fix: Remove cache access at Django project startup

845995c

fsbraun temporarily deployed to test May 9, 2025 06:23 — with GitHub Actions Inactive

fix tests

0b914e8

fsbraun temporarily deployed to test May 10, 2025 07:37 — with GitHub Actions Inactive

Update release notes

fb0e4dd

fsbraun temporarily deployed to test May 10, 2025 13:34 — with GitHub Actions Inactive

Update Changelog

b2d7926

fsbraun temporarily deployed to test May 10, 2025 13:37 — with GitHub Actions Inactive

Fix typos in Changelog

48a3faa

fsbraun temporarily deployed to test May 10, 2025 13:45 — with GitHub Actions Inactive

fsbraun marked this pull request as ready for review May 11, 2025 07:29

sourcery-ai bot reviewed May 11, 2025

View reviewed changes

Update CHANGELOG.rst

f63312b

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

fsbraun temporarily deployed to test May 11, 2025 07:46 — with GitHub Actions Inactive

Update CHANGELOG.rst

d491f87

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

fsbraun temporarily deployed to test May 11, 2025 07:46 — with GitHub Actions Inactive

Update CHANGELOG.rst

b1a70f2

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

fsbraun temporarily deployed to test May 11, 2025 07:47 — with GitHub Actions Inactive

Update docs/upgrade/4.1.4.rst

21e8003

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

fsbraun temporarily deployed to test May 11, 2025 07:47 — with GitHub Actions Inactive

Update docs/upgrade/4.1.2.rst

a038b29

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

fsbraun temporarily deployed to test May 11, 2025 07:47 — with GitHub Actions Inactive

Update docs/upgrade/4.1.3.rst

70910c4

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

fsbraun temporarily deployed to test May 11, 2025 07:48 — with GitHub Actions Inactive

Update docs/upgrade/4.1.6.rst

0c0839f

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

fsbraun temporarily deployed to test May 11, 2025 07:48 — with GitHub Actions Inactive

Update docs/upgrade/4.1.3.rst

34bc113

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

fsbraun temporarily deployed to test May 11, 2025 07:48 — with GitHub Actions Inactive

Update docs/upgrade/4.1.2.rst

f30395e

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

fsbraun temporarily deployed to test May 11, 2025 07:50 — with GitHub Actions Inactive

fsbraun commented May 11, 2025

View reviewed changes

docs/upgrade/4.1.2.rst Outdated Show resolved Hide resolved

Update docs/upgrade/4.1.2.rst

a2aa1a0

fsbraun temporarily deployed to test May 11, 2025 07:50 — with GitHub Actions Inactive

vinitkumar approved these changes May 11, 2025

View reviewed changes

vinitkumar merged commit 0f633fc into develop-4 May 11, 2025
66 checks passed

github-actions bot deleted the release/build branch May 12, 2025 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: Merge back django CMS 5.0.0 build #8220

chore: Merge back django CMS 5.0.0 build #8220

fsbraun commented May 8, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented May 8, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chore: Merge back django CMS 5.0.0 build #8220

chore: Merge back django CMS 5.0.0 build #8220

Conversation

fsbraun commented May 8, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related resources

Checklist

Summary by Sourcery

Summary by Sourcery

Uh oh!

sourcery-ai bot commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fsbraun commented May 8, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented May 8, 2025 •

edited

Loading