Skip to content

fix: CI errors #8268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

fix: CI errors #8268

merged 1 commit into from
Jun 28, 2025

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jun 28, 2025 •
edited by sourcery-ai bot
Loading

Description

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against main
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Bug Fixes:

  • Import get_entries and get_entry from wizard_base instead of helpers to fix missing import errors

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jun 28, 2025 •
edited
Loading

Reviewer's Guide

Consolidated import statements in cms/wizards/wizard_pool.py by moving get_entries and get_entry into the wizard_base import to resolve CI errors and reduce redundant imports.

Class diagram for updated imports in wizard_pool.py

classDiagram
    class wizard_pool {
        +AlreadyRegisteredException
    }
    class wizard_base {
        +Wizard
        +entry_choices
        +get_entries
        +get_entry
    }
    wizard_pool ..> wizard_base : imports
Loading

File-Level Changes

Change Details Files
Consolidated wizard imports to fix CI errors
  • Removed separate import from cms.wizards.helpers
  • Merged two import statements into one
  • Added get_entries and get_entry to the wizard_base import line
 cms/wizards/wizard_pool.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions GitHub Actions
Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from main!

Do not SQUASH commits to preserve history for the changelog.

@fsbraun fsbraun marked this pull request as ready for review June 28, 2025 17:06
@fsbraun fsbraun merged commit 8b58e3d into release/5.0.x Jun 28, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fsbraun