Skip to content

fix: Update deprecation warning to current version numbers #8269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cms/admin/placeholderadmin.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
from cms.signals import post_placeholder_operation, pre_placeholder_operation
from cms.toolbar.utils import get_plugin_tree_as_json
from cms.utils import get_current_site
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS60Warning
from cms.utils.conf import get_cms_setting
from cms.utils.i18n import get_language_code, get_language_list
from cms.utils.plugins import (
Expand Down Expand Up @@ -180,7 +180,7 @@ def __new__(cls, name, bases, attrs):
return super_new(cls, name, bases, attrs)
warnings.warn(
"PlaceholderAdminMixin is no longer needed and thus will be removed in django CMS 5.0",
RemovedInDjangoCMS50Warning,
RemovedInDjangoCMS60Warning,
stacklevel=2,
)
return super_new(cls, name, bases, attrs)
Expand Down
4 changes: 2 additions & 2 deletions cms/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def my_function():
from cms.plugin_base import CMSPluginBase
from cms.plugin_pool import plugin_pool
from cms.utils import get_current_site
from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.conf import get_cms_setting
from cms.utils.i18n import get_language_list
from cms.utils.page import get_available_slug, get_clean_username
Expand Down Expand Up @@ -363,7 +363,7 @@ def create_title(language, title, page, menu_title=None, slug=None,
"""
warnings.warn(
"cms.api.create_title has been renamed to cms.api.create_page_content().",
RemovedInDjangoCMS43Warning,
RemovedInDjangoCMS50Warning,
stacklevel=2
)
return create_page_content(
Expand Down
4 changes: 2 additions & 2 deletions cms/cms_plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from cms.models.placeholderpluginmodel import PlaceholderReference
from cms.plugin_base import CMSPluginBase, PluginMenuItem
from cms.plugin_pool import plugin_pool
from cms.utils.compat.warnings import RemovedInDjangoCMS42Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.urlutils import admin_reverse


Expand Down Expand Up @@ -117,7 +117,7 @@ def create_alias(self, request):
'AliasPlugin is deprecated, '
'and it will be removed; '
'please use the package djangocms-alias instead',
RemovedInDjangoCMS42Warning
RemovedInDjangoCMS50Warning
)
if not request.user.is_staff:
return HttpResponseForbidden("not enough privileges")
Expand Down
6 changes: 3 additions & 3 deletions cms/cms_toolbars.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from cms.toolbar_pool import toolbar_pool
from cms.utils import get_language_from_request, page_permissions
from cms.utils.compat import DJANGO_4_2
from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.conf import get_cms_setting
from cms.utils.i18n import get_language_dict, get_language_tuple
from cms.utils.page_permissions import (
Expand Down Expand Up @@ -439,7 +439,7 @@ def title(self):

warnings.warn(
"Title property of PageToolbar will be removed. Use page_content property instead.",
RemovedInDjangoCMS43Warning, stacklevel=2)
RemovedInDjangoCMS50Warning, stacklevel=2)
return self.page_content

@title.setter
Expand All @@ -448,7 +448,7 @@ def title(self, page_content):

warnings.warn(
"Title property of PageToolbar will be removed. Use page_content property instead.",
RemovedInDjangoCMS43Warning, stacklevel=2)
RemovedInDjangoCMS50Warning, stacklevel=2)
self.page_content = page_content

# Populate
Expand Down
4 changes: 2 additions & 2 deletions cms/extensions/toolbar.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from cms.models import PageContent
from cms.toolbar_base import CMSToolbar
from cms.utils import get_language_list
from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.page_permissions import user_can_change_page
from cms.utils.urlutils import admin_reverse

Expand Down Expand Up @@ -86,7 +86,7 @@ def get_title_extension_admin(self, language=None):
"""
warnings.warn(
"get_title_extension_admin has been deprecated and replaced by get_page_content_extension_admin",
RemovedInDjangoCMS43Warning,
RemovedInDjangoCMS50Warning,
stacklevel=2,
)
urls = []
Expand Down
6 changes: 3 additions & 3 deletions cms/forms/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@
from cms.forms.widgets import PageSelectWidget, PageSmartLinkWidget
from cms.models.pagemodel import Page
from cms.utils.compat import DJANGO_4_2
from cms.utils.compat.warnings import RemovedInDjangoCMS42Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning


class SuperLazyIterator:
def __init__(self, func):
warnings.warn("SuperLazyIterator is deprecated.",
RemovedInDjangoCMS42Warning, stacklevel=2)
RemovedInDjangoCMS50Warning, stacklevel=2)
self.func = func

def __iter__(self):
Expand All @@ -28,7 +28,7 @@ class LazyChoiceField(forms.ChoiceField):

def __init__(self, *args, **kwargs):
warnings.warn("LazyChoiceField is deprecated. Use Django's ChoiceField instead.",
RemovedInDjangoCMS42Warning, stacklevel=2)
RemovedInDjangoCMS50Warning, stacklevel=2)
super().__init__(*args, **kwargs)

@property
Expand Down
4 changes: 2 additions & 2 deletions cms/forms/wizards.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from cms.admin.forms import AddPageForm, SlugWidget as AdminSlugWidget
from cms.plugin_pool import plugin_pool
from cms.utils import permissions
from cms.utils.compat.warnings import RemovedInDjangoCMS42Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.conf import get_cms_setting
from cms.utils.page import get_available_slug
from cms.utils.page_permissions import user_can_add_page, user_can_add_subpage
Expand All @@ -27,7 +27,7 @@ class SlugWidget(AdminSlugWidget):
SlugWidget has moved to cms.admin.forms"""
def __init__(self, *args, **kwargs):
warnings.warn("Import SlugWidget from cms.admin.forms. SlugWidget will be removed from cms.forms.wizards",
RemovedInDjangoCMS42Warning, stacklevel=2)
RemovedInDjangoCMS50Warning, stacklevel=2)
super().__init__(*args, **kwargs)


Expand Down
4 changes: 2 additions & 2 deletions cms/models/pagemodel.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from cms.exceptions import LanguageError
from cms.models.managers import PageManager, PageNodeManager, PageUrlManager
from cms.utils import i18n
from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.conf import get_cms_setting
from cms.utils.i18n import get_current_language
from cms.utils.page import get_clean_username
Expand Down Expand Up @@ -737,7 +737,7 @@ def set_translations_cache(self):
warnings.warn(
"Method `set_translations_cache` is deprecated. Use `get_content_obj` instead. "
"For admin views use `set_admin_content_cache` instead.",
RemovedInDjangoCMS43Warning,
RemovedInDjangoCMS50Warning,
stacklevel=2,
)
for translation in self.pagecontent_set.all():
Expand Down
4 changes: 2 additions & 2 deletions cms/models/permissionmodels.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,9 @@ def get_page_permission_tuple(self):
def get_page_ids(self):
import warnings

from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
warnings.warn("get_page_ids is deprecated and will be removed in django CMS 4.3, "
"use get_page_permission_tuple instead", RemovedInDjangoCMS43Warning, stacklevel=2)
"use get_page_permission_tuple instead", RemovedInDjangoCMS50Warning, stacklevel=2)

return self._get_page_ids()

Expand Down
4 changes: 2 additions & 2 deletions cms/templatetags/cms_alias_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from django.utils.safestring import mark_safe

from cms.toolbar.utils import get_toolbar_from_request
from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.plugins import downcast_plugins, get_plugins_as_layered_tree

register = template.Library()
Expand All @@ -16,7 +16,7 @@ def render_alias_plugin(context, instance):
'AliasPlugin is deprecated, '
'and it will be removed; '
'please use the package djangocms-alias instead',
RemovedInDjangoCMS43Warning
RemovedInDjangoCMS50Warning
)

request = context['request']
Expand Down
4 changes: 2 additions & 2 deletions cms/test_utils/testcases.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ def add_page_permission(self, user, page, **kwargs):
def get_page_title_obj(self, page, language="en"):
import warnings

from cms.utils.compat.warnings import RemovedInDjangoCMS42Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning

warnings.warn(
"get_page_title_obj is deprecated, use get_pagecontent_obj instead",
RemovedInDjangoCMS42Warning,
RemovedInDjangoCMS50Warning,
stacklevel=2,
)
return PageContent.objects.get(page=page, language=language)
Expand Down
4 changes: 2 additions & 2 deletions cms/tests/test_extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
)
from cms.test_utils.testcases import CMSTestCase
from cms.toolbar_pool import toolbar_pool
from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.urlutils import admin_reverse


Expand Down Expand Up @@ -437,7 +437,7 @@ def populate(self):
message = "get_title_extension_admin has been deprecated and replaced by get_page_content_extension_admin"
with self.login_user_context(self.admin):
self.assertWarns(
RemovedInDjangoCMS43Warning,
RemovedInDjangoCMS50Warning,
message,
lambda: self.client.get(self.page.get_absolute_url()),
)
Expand Down
7 changes: 2 additions & 5 deletions cms/utils/compat/warnings.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
class RemovedInDjangoCMS42Warning(DeprecationWarning):
pass

class RemovedInDjangoCMS43Warning(DeprecationWarning):
class RemovedInDjangoCMS50Warning(DeprecationWarning):
pass

class RemovedInDjangoCMS50Warning(DeprecationWarning):
class RemovedInDjangoCMS60Warning(DeprecationWarning):
pass
4 changes: 2 additions & 2 deletions cms/utils/page_permissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from cms.models import Page, PermissionTuple
from cms.utils import get_current_site
from cms.utils.compat.dj import available_attrs
from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.conf import get_cms_setting
from cms.utils.permissions import (
cached_func,
Expand Down Expand Up @@ -360,7 +360,7 @@ def _perm_tuples_to_ids(perm_tuples):

fn_name = "_".join(inspect.stack()[1][3].split("_")[:-1]) # Calling function's name
warnings.warn(f"{fn_name}_ids is deprecated. Use {fn_name}_perm_tuples instead.",
RemovedInDjangoCMS43Warning, stacklevel=3)
RemovedInDjangoCMS50Warning, stacklevel=3)

allowed_pages = Q()
for perm in perm_tuples:
Expand Down
8 changes: 4 additions & 4 deletions cms/utils/permissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,12 @@ def has_global_permission(user, site, action, use_cache=True):
def has_page_permission(user, page, action, use_cache=True):
import warnings

from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.page_permissions import has_generic_permission

warnings.warn("has_page_permission is deprecated and will be removed in django CMS 4.3. "
"Use cms.utils.page_permissions.has_generic_permission instead.",
RemovedInDjangoCMS43Warning, stacklevel=2)
RemovedInDjangoCMS50Warning, stacklevel=2)

action_map = {
"change": "change_page",
Expand Down Expand Up @@ -334,10 +334,10 @@ def get_view_restrictions(pages):
Load all view restrictions for the pages
"""

from cms.utils.compat.warnings import RemovedInDjangoCMS43Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning

warnings.warn("get_view_restrictions will be removed in django CMS 4.3",
RemovedInDjangoCMS43Warning, stacklevel=2)
RemovedInDjangoCMS50Warning, stacklevel=2)

restricted_pages = defaultdict(list)

Expand Down
4 changes: 2 additions & 2 deletions cms/wizards/wizard_pool.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from django.apps import apps
from django.utils.translation import gettext as _

from cms.utils.compat.warnings import RemovedInDjangoCMS50Warning
from cms.utils.compat.warnings import RemovedInDjangoCMS60Warning
from cms.wizards.wizard_base import Wizard, entry_choices, get_entries, get_entry # noqa: F401


Expand Down Expand Up @@ -43,7 +43,7 @@ def register(self, entry):

warnings.warn(
"Using wizard_pool is deprecated. Use the cms_config instead.",
RemovedInDjangoCMS50Warning,
RemovedInDjangoCMS60Warning,
stacklevel=2,
)
assert isinstance(entry, Wizard), "entry must be an instance of Wizard"
Expand Down
Loading