Skip to content

fix: Allow clicks to propagate to plugins (#8288) #8289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

fix: Allow clicks to propagate to plugins (#8288) #8289

merged 1 commit into from
Jul 11, 2025

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jul 11, 2025 •
edited
Loading

Description

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against main
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Bug Fixes:

  • Allow clicks to propagate to plugins by removing preventDefault and stopPropagation calls and updating the handler signature

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jul 11, 2025 •
edited
Loading

Reviewer's Guide

Modified the click-to-highlight handler in cms.plugins.js to remove event suppression and allow clicks to propagate to underlying plugin elements in structure mode.

Sequence diagram for click event propagation in plugin structure mode

sequenceDiagram
    actor User
    participant Plugin as Plugin._clickToHighlightHandler
    participant StructureBoard as CMS.API.StructureBoard
    User->>Plugin: Click event
    Note right of Plugin: (No preventDefault/stopPropagation)
    Plugin->>StructureBoard: _showAndHighlightPlugin(200, true)
    Note right of Plugin: Event propagates to underlying plugins
Loading

File-Level Changes

Change Details Files
Allow clicks to propagate by removing event prevention and propagation blocking
  • Removed the event parameter from the click handler signature
  • Deleted e.preventDefault() call
  • Deleted e.stopPropagation() call
 cms/static/cms/js/modules/cms.plugins.js

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions GitHub Actions
Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from main!

Do not SQUASH commits to preserve history for the changelog.

@fsbraun fsbraun merged commit 2c1ab2d into release/5.0.x Jul 11, 2025
72 checks passed
@fsbraun fsbraun deleted the chore/backport-8288 branch July 11, 2025 17:06
@fsbraun fsbraun restored the chore/backport-8288 branch July 15, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fsbraun