Skip to content

fix: Removed inline CSS from headless template (#8291) #8292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jul 15, 2025

Description

Related resources

  • #...
  • #...

Checklist

Summary by Sourcery

Externalize inline CSS from the headless placeholder template into a dedicated stylesheet and update the template to load it via the static tag.

Enhancements:

  • Move inline CSS from placeholder.html into a new cms.headless.scss file under static assets
  • Update headless placeholder template to load the external cms.headless.css via static_with_version
  • Add cms_static tag to template to support loading the new stylesheet

Copy link
Contributor

sourcery-ai bot commented Jul 15, 2025

Reviewer's Guide

Externalizes inline CSS from the headless placeholder template into a dedicated SCSS file and updates the template to use the new stylesheet via the static_with_version tag.

File-Level Changes

Change Details Files
Replaced inline CSS in placeholder.html with a linked stylesheet
  • Added cms_static tag for asset loading
  • Removed the inline <style> block
  • Inserted tag referencing cms/css/cms.headless.css via static_with_version
cms/templates/cms/headless/placeholder.html
Added new SCSS file for headless placeholder styles
  • Created cms.headless.scss and imported global settings
  • Ported style rules from the template into SASS
  • Defined section, heading, and image styles using theme variables
cms/static/cms/sass/cms.headless.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from main!

Do not SQUASH commits to preserve history for the changelog.

@fsbraun fsbraun changed the title fix: The headless template included inline CSS (#8291) fix: Removed inline CSS from headless template (#8291) Jul 15, 2025
@fsbraun fsbraun merged commit 14dd89f into release/5.0.x Jul 15, 2025
70 checks passed
@fsbraun fsbraun deleted the chore/backport-8291 branch July 15, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant