Mock filter_admin_model #211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By mocking this method we will be able to filter from the entire queryset rather than the queryset limited to published objects
8f46a83 to
b58af4c
Compare
|
Closing as the PR mentioned above has also been closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By mocking this method we will be able to filter from the entire queryset
rather than the queryset limited to published objects
The reason for introducing this in the first place was that the toolbar needs to access to be able to access an object that is draft and it should not rely on
page.get_titleto fetch the correct object as that method will fetch fallbacks which may not be correct for our purposes.This PR depends on: django-cms/django-cms#6817 for tests to succeed.