fix: Adds compatibility for User models with no username field [#292] #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 85.17% 86.91% +1.74%
==========================================
Files 24 30 +6
Lines 931 1743 +812
Branches 141 269 +128
==========================================
+ Hits 793 1515 +722
- Misses 108 173 +65
- Partials 30 55 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fsbraun
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I use a
Usermodel which has no username, thereforeget_queryset()fails because there's nousernameattribute on theUser.This allows a project to specify what field on
Usercan be used to identify a user.This doesn't include proper testing, but to test this properly it needs a custom model, a corresponding model manager that can create users without a username. I'm hesitant to add these to the project, so if anybody has any suggestions on how to test against this I'd love to hear them.
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.