feat: add localization and transifex support #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 89.75% 89.75%
=======================================
Files 67 67
Lines 2196 2196
Branches 293 293
=======================================
Hits 1971 1971
Misses 170 170
Partials 55 55 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Update readme
marksweb
approved these changes
Jan 11, 2023
| @@ -19,7 +19,7 @@ <h4>{% blocktrans %} Version number: {{ version_number }}{% endblocktrans %}</h4 | |||
| {% csrf_token %} | |||
| <input class="button confirm-link js-versioning-keep-sideframe" | |||
| type="submit" | |||
| value="{% trans 'Yes, I\'m sure' %}"> | |||
| value="{% trans "Yes, I\'m sure" %}"> | |||
There was a problem hiding this comment.
We might be better off using translate as the tagname.
trans still exists as an alias in django main, but I think it'll get removed at some point.
You also don't need to escape the inverted comma now that you're double quoting the string.
There was a problem hiding this comment.
True. I've replaced all {% trans %} tags with {% translate %}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds localization and transifex support.
.tx/config./manage.py makemessages --allcreates the correct stringsRelated resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.