Skip to content

Some fixed strings are now translatable #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2023

Conversation

svandeneertwegh
Copy link
Contributor

Description

constants.py = 4 fixed strings which dit not parsed through _()
models.py = 2 date fields which did not had verbose_name

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

2 date fields which did not have verbose_name in language mode.
4 fixed human_names are set without _() language support
@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #310 (3f9705a) into master (b77ef6f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          68       68           
  Lines        2242     2242           
  Branches      299      299           
=======================================
  Hits         2015     2015           
  Misses        172      172           
  Partials       55       55           
Impacted Files Coverage Δ
djangocms_versioning/models.py 94.85% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fsbraun
Copy link
Member

fsbraun commented Jan 22, 2023

@svandeneertwegh Can you please run django-admin makemessages --all in the djangocms_versioning folder and include the update po files in the PR?

@fsbraun fsbraun merged commit 52a4f89 into django-cms:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants